Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/internal/browser/BrowserLaunchConfigurationDelegate.java

Issue 9950059: improved logging when javascript is not generated (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/internal/browser/BrowserLaunchConfigurationDelegate.java
===================================================================
--- editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/internal/browser/BrowserLaunchConfigurationDelegate.java (revision 6092)
+++ editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/internal/browser/BrowserLaunchConfigurationDelegate.java (working copy)
@@ -157,11 +157,13 @@
if (result.getExitCode() != 0) {
String errMsg = NLS.bind(
- "Failure to launch - unable to generate JavaScript for {0}.\n\nPlease see console for more details.",
+ "Failure to launch - unable to generate JavaScript for {0}.\n\nPlease see console or log for more details.",
devoncarew 2012/04/02 17:34:11 the console
resource.getName());
errMsg = errMsg.trim();
+ DartDebugCorePlugin.logError(result.getAllOutput());
+
throw new CoreException(new Status(IStatus.ERROR, DartDebugUIPlugin.PLUGIN_ID, errMsg));
}
} else {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698