Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 995005: Fix a bug in the regexp caching. Also add a few more places to... (Closed)

Created:
10 years, 9 months ago by Erik Corry
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix a bug in the regexp caching. Also add a few more places to cache. We now cache most of the places where Opera cache and one or two where they do not cache for some reason. Since these optimizations aren't necessarily useful on real code we may remove them if and when the Dromaeo website makes the benchmarks harder to game. Committed: http://code.google.com/p/v8/source/detail?r=4157

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -51 lines) Patch
M src/regexp-delay.js View 9 chunks +61 lines, -32 lines 0 comments Download
M src/string.js View 7 chunks +65 lines, -19 lines 0 comments Download
A test/mjsunit/regexp-cache-replace.js View 1 chunk +36 lines, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Erik Corry
10 years, 9 months ago (2010-03-17 10:18:39 UTC) #1
Mads Ager (chromium)
10 years, 9 months ago (2010-03-17 10:22:23 UTC) #2
LGTM

http://codereview.chromium.org/995005/diff/1/4
File test/mjsunit/regexp-cache-replace.js (right):

http://codereview.chromium.org/995005/diff/1/4#newcode1
test/mjsunit/regexp-cache-replace.js:1: // Copyright 2009 the V8 project
authors. All rights reserved.
2010

Powered by Google App Engine
This is Rietveld 408576698