Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Side by Side Diff: chrome/common/extensions/simple_feature_provider_unittest.cc

Issue 9950046: Implement FeatureProvider for ExtensionAPI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/simple_feature_provider.h" 5 #include "chrome/common/extensions/simple_feature_provider.h"
6 6
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 using extensions::Feature; 9 using extensions::Feature;
10 using extensions::SimpleFeatureProvider; 10 using extensions::SimpleFeatureProvider;
11 11
12 TEST(SimpleFeatureProvider, ManifestFeatures) { 12 TEST(SimpleFeatureProvider, ManifestFeatures) {
13 SimpleFeatureProvider* provider = 13 SimpleFeatureProvider* provider =
14 SimpleFeatureProvider::GetManifestFeatures(); 14 SimpleFeatureProvider::GetManifestFeatures();
15 scoped_ptr<Feature> feature = provider->GetFeature("name"); 15 scoped_ptr<Feature> feature = provider->GetFeature("description");
16 ASSERT_TRUE(feature.get()); 16 ASSERT_TRUE(feature.get());
17 EXPECT_EQ(5u, feature->extension_types()->size()); 17 EXPECT_EQ(5u, feature->extension_types()->size());
18 EXPECT_EQ(1u, feature->extension_types()->count(Extension::TYPE_EXTENSION));
19 EXPECT_EQ(1u,
20 feature->extension_types()->count(Extension::TYPE_PACKAGED_APP));
21 EXPECT_EQ(1u,
22 feature->extension_types()->count(Extension::TYPE_PLATFORM_APP));
23 EXPECT_EQ(1u, feature->extension_types()->count(Extension::TYPE_HOSTED_APP));
24 EXPECT_EQ(1u, feature->extension_types()->count(Extension::TYPE_THEME));
25
26 DictionaryValue manifest;
27 manifest.SetString("name", "test extension");
28 manifest.SetString("version", "1");
29 manifest.SetString("description", "hello there");
30
31 std::string error;
32 scoped_refptr<const Extension> extension(Extension::Create(
33 FilePath(), Extension::INTERNAL, manifest, Extension::NO_FLAGS,
34 &error));
35
36 ASSERT_TRUE(extension.get());
37 EXPECT_EQ(Feature::IS_AVAILABLE, feature->IsAvailableToContext(
38 extension.get(), Feature::UNSPECIFIED_CONTEXT));
39
40 feature = provider->GetFeature("theme");
41 ASSERT_TRUE(feature.get());
42 EXPECT_EQ(Feature::INVALID_TYPE, feature->IsAvailableToContext(
43 extension.get(), Feature::UNSPECIFIED_CONTEXT));
44
45 feature = provider->GetFeature("devtools_page");
46 ASSERT_TRUE(feature.get());
47 EXPECT_EQ(Feature::NOT_PRESENT, feature->IsAvailableToContext(
48 extension.get(), Feature::UNSPECIFIED_CONTEXT));
49 }
50
51 TEST(SimpleFeatureProvider, PermissionFeatures) {
52 SimpleFeatureProvider* provider =
53 SimpleFeatureProvider::GetPermissionFeatures();
54 scoped_ptr<Feature> feature = provider->GetFeature("browsingData");
55 ASSERT_TRUE(feature.get());
56 EXPECT_EQ(3u, feature->extension_types()->size());
57 EXPECT_EQ(1u, feature->extension_types()->count(Extension::TYPE_EXTENSION));
58 EXPECT_EQ(1u,
59 feature->extension_types()->count(Extension::TYPE_PACKAGED_APP));
60 EXPECT_EQ(1u,
61 feature->extension_types()->count(Extension::TYPE_PLATFORM_APP));
62
63 DictionaryValue manifest;
64 manifest.SetString("name", "test extension");
65 manifest.SetString("version", "1");
66 ListValue* permissions = new ListValue();
67 manifest.Set("permissions", permissions);
68 permissions->Append(Value::CreateStringValue("browsingData"));
69
70 std::string error;
71 scoped_refptr<const Extension> extension(Extension::Create(
72 FilePath(), Extension::INTERNAL, manifest, Extension::NO_FLAGS,
73 &error));
74
75 ASSERT_TRUE(extension.get());
76 EXPECT_EQ(Feature::IS_AVAILABLE, feature->IsAvailableToContext(
77 extension.get(), Feature::UNSPECIFIED_CONTEXT));
78
79 feature = provider->GetFeature("chromePrivate");
80 ASSERT_TRUE(feature.get());
81 EXPECT_EQ(Feature::NOT_FOUND_IN_WHITELIST, feature->IsAvailableToContext(
82 extension.get(), Feature::UNSPECIFIED_CONTEXT));
83
84 feature = provider->GetFeature("clipboardWrite");
85 ASSERT_TRUE(feature.get());
86 EXPECT_EQ(Feature::NOT_PRESENT, feature->IsAvailableToContext(
87 extension.get(), Feature::UNSPECIFIED_CONTEXT));
18 } 88 }
19 89
20 TEST(SimpleFeatureProvider, Validation) { 90 TEST(SimpleFeatureProvider, Validation) {
21 scoped_ptr<DictionaryValue> value(new DictionaryValue()); 91 scoped_ptr<DictionaryValue> value(new DictionaryValue());
22 92
23 DictionaryValue* feature1 = new DictionaryValue(); 93 DictionaryValue* feature1 = new DictionaryValue();
24 value->Set("feature1", feature1); 94 value->Set("feature1", feature1);
25 95
26 DictionaryValue* feature2 = new DictionaryValue(); 96 DictionaryValue* feature2 = new DictionaryValue();
27 ListValue* extension_types = new ListValue(); 97 ListValue* extension_types = new ListValue();
28 extension_types->Append(Value::CreateStringValue("extension")); 98 extension_types->Append(Value::CreateStringValue("extension"));
29 feature2->Set("extension_types", extension_types); 99 feature2->Set("extension_types", extension_types);
30 ListValue* contexts = new ListValue(); 100 ListValue* contexts = new ListValue();
31 contexts->Append(Value::CreateStringValue("blessed_extension")); 101 contexts->Append(Value::CreateStringValue("blessed_extension"));
32 feature2->Set("contexts", contexts); 102 feature2->Set("contexts", contexts);
33 value->Set("feature2", feature2); 103 value->Set("feature2", feature2);
34 104
35 SimpleFeatureProvider provider(value.Pass()); 105 SimpleFeatureProvider provider(value.Pass(), NULL);
36 106
37 // feature1 won't validate because it lacks an extension type. 107 // feature1 won't validate because it lacks an extension type.
38 EXPECT_FALSE(provider.GetFeature("feature1").get()); 108 EXPECT_FALSE(provider.GetFeature("feature1").get());
39 109
40 // If we add one, it works. 110 // If we add one, it works.
41 feature1->Set("extension_types", extension_types->DeepCopy()); 111 feature1->Set("extension_types", extension_types->DeepCopy());
42 EXPECT_TRUE(provider.GetFeature("feature1").get()); 112 EXPECT_TRUE(provider.GetFeature("feature1").get());
43 113
44 // feature2 won't validate because of the presence of "contexts". 114 // feature2 won't validate because of the presence of "contexts".
45 EXPECT_FALSE(provider.GetFeature("feature2").get()); 115 EXPECT_FALSE(provider.GetFeature("feature2").get());
46 116
47 // If we remove it, it works. 117 // If we remove it, it works.
48 feature2->Remove("contexts", NULL); 118 feature2->Remove("contexts", NULL);
49 EXPECT_TRUE(provider.GetFeature("feature2").get()); 119 EXPECT_TRUE(provider.GetFeature("feature2").get());
50 } 120 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698