Get chrome:// dev tool urls hooked up in content_shell.

chrome/app/chrome_main_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/app/chrome_main_delegate.h"
 
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
 #include "base/message_loop.h"
 #include "base/metrics/field_trial.h"
@@ skipping 430 matching lines @@
   if (HasDeprecatedArguments(command_line.GetCommandLineString())) {
     *exit_code = 1;
     return true;
   }
 #endif
 
   if (!command_line.HasSwitch(switches::kProcessType) &&
       command_line.HasSwitch(switches::kEnableBenchmarking)) {
     base::FieldTrial::EnableBenchmarking();
   }
+
+  // Initialize the content client very early on in the main initialization
+  // sequence, ContentMainRunner depends on methods of ContentClient, in
+  // particular the AddAdditionalSchemes() method which returns internal Chrome
+  // schemes to be registered with googleurl has having the standard
+  // <scheme>://<host>:<port>/<path> parsing semantics. This must happen before
+  // processing any URLs with the affected schemes, and must be done in all
+  // processes that work with these URLs (i.e. including renderers).

[jam, 2012/04/17 03:30:10]

nit: this comment is describing what the code does and not something, which
someone reading the code can figure out. so it shouldn't be needed, per the
style guide about comments

[michaeln, 2012/04/17 04:08:26]

How about i leave it at...
// Initialize the content client very early to allow chrome's custom url
// schemes to be properly registered.

[jam, 2012/04/17 04:49:51]

I think that's still documenting why something is done. this can change in the
future (i.e. someone adds another ContentClient::Get() call earlier). if someone
really wants to try to move it, they'll figure out why it's in that place..

[michaeln, 2012/04/17 19:23:32]

Ok, removed these retained comments. Fyi, there are others of this form
throughout this file.

+  std::string process_type =  command_line.GetSwitchValueASCII(
+      switches::kProcessType);
+  content::SetContentClient(&chrome_content_client_);
+  InitializeChromeContentClient(process_type);
+
   return false;
 }
 
 #if defined(OS_MACOSX)
 void ChromeMainDelegate::InitMacCrashReporter(const CommandLine& command_line,
                                               const std::string& process_type) {
   // TODO(mark): Right now, InitCrashReporter() needs to be called after
   // CommandLine::Init() and chrome::RegisterPathProvider().  Ideally,
   // Breakpad initialization could occur sooner, preferably even before the
   // framework dylib is even loaded, to catch potential early crashes.
@@ skipping 76 matching lines @@
   if (IsCrashReporterEnabled())
     InitCrashProcessInfo();
 }
 #endif  // defined(OS_MACOSX)
 
 void ChromeMainDelegate::PreSandboxStartup() {
   const CommandLine& command_line = *CommandLine::ForCurrentProcess();
   std::string process_type =
       command_line.GetSwitchValueASCII(switches::kProcessType);
 
-  // Initialize the content client which that code uses to talk to Chrome.
-  content::SetContentClient(&chrome_content_client_);
-  InitializeChromeContentClient(process_type);
-
   // Initialize the Chrome path provider.
   chrome::RegisterPathProvider();
 
 #if defined(OS_MACOSX)
   // On the Mac, the child executable lives at a predefined location within
   // the app bundle's versioned directory.
   PathService::Override(content::CHILD_PROCESS_EXE,
                         chrome::GetVersionedDirectory().
                         Append(chrome::kHelperProcessExecutablePath));
 
@@ skipping 28 matching lines @@
   }
 #endif  // GOOGLE_CHROME_BUILD
 
   logging::OldFileDeletionState file_state =
       logging::APPEND_TO_OLD_LOG_FILE;
   if (process_type.empty()) {
     file_state = logging::DELETE_OLD_LOG_FILE;
   }
   logging::InitChromeLogging(command_line, file_state);
 
-  // Register internal Chrome schemes so they'll be parsed correctly. This
-  // must happen before we process any URLs with the affected schemes, and
-  // must be done in all processes that work with these URLs (i.e. including
-  // renderers).
-  chrome::RegisterChromeSchemes();
-
 #if defined(OS_WIN)
   // TODO(darin): Kill this once http://crbug.com/52609 is fixed.
   ui::SetResourcesDataDLL(_AtlBaseModule.GetResourceInstance());
 #endif
 
   if (SubprocessNeedsResourceBundle(process_type)) {
     // Initialize ResourceBundle which handles files loaded from external
     // sources.  The language should have been passed in to us from the
     // browser process as a command line flag.
     DCHECK(command_line.HasSwitch(switches::kLang) ||
@@ skipping 121 matching lines @@
 
 #if defined(USE_LINUX_BREAKPAD)
   // Needs to be called after we have chrome::DIR_USER_DATA.  BrowserMain sets
   // this up for the browser process in a different manner.
   InitCrashReporter();
 #endif
 
   InitializeChromeContentClient(process_type);
 }
 #endif  // OS_MACOSX