Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 995004: Factoring duplicate code from platform-specific LoginHandlers into a base ... (Closed)

Created:
10 years, 9 months ago by tonyg
Modified:
9 years, 6 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Factoring duplicate code from platform-specific LoginHandlers into a base LoginHandler class. As pointed out by erg, it would be cleaner to use a separate controller class, but this simple refactor should make that easier. Originally submitted as 41739, however that patch had to be reverted because I had accidentally changed an if (!...) { NOTREACHED(); } into a DCHECK(...) in the LoginHandler ctor. That is fixed now. BUG=14909 TEST=ui_tests --gtest_filter=LoginPromptTest* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42368

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -616 lines) Patch
M chrome/browser/login_prompt.h View 1 2 chunks +73 lines, -24 lines 0 comments Download
M chrome/browser/login_prompt.cc View 1 2 chunks +184 lines, -0 lines 0 comments Download
M chrome/browser/login_prompt_gtk.cc View 1 6 chunks +11 lines, -202 lines 0 comments Download
M chrome/browser/login_prompt_mac.mm View 1 2 chunks +15 lines, -207 lines 0 comments Download
M chrome/browser/login_prompt_win.cc View 1 4 chunks +24 lines, -183 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tonyg
I made a totally braindead mistake before by guarding a call that should always happen ...
10 years, 9 months ago (2010-03-17 19:33:39 UTC) #1
Elliot Glaysher
LGTM, but you're going to have to get someone else to commit it. I'm out ...
10 years, 9 months ago (2010-03-17 21:06:04 UTC) #2
tonyg
10 years, 9 months ago (2010-03-19 16:28:53 UTC) #3
On 2010/03/17 21:06:04, Elliot Glaysher wrote:
> LGTM, but you're going to have to get someone else to commit it. I'm out sick.

Hi Eric, Your name showed up on blame for login_prompt.cc. Would you mind taking
a brief look at this and landing it if you are okay with it? Thanks, Tony

Powered by Google App Engine
This is Rietveld 408576698