Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 9949038: Fix Pepper file chooser (Closed)

Created:
8 years, 8 months ago by yzshen1
Modified:
8 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Fix Pepper file chooser: - handle the case that PPB_FileChooser_Impl::StoreChosenFiles is called when the corresponding callback has been aborted. - avoid leaking FileChooserCompletionImpl. BUG=121081 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131101

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M webkit/plugins/ppapi/ppb_file_chooser_impl.cc View 3 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yzshen1
Hi, Brett. Would you please take a look? Thanks!
8 years, 8 months ago (2012-04-05 22:29:49 UTC) #1
brettw
LGTM. Thanks for fixing my bugs :P
8 years, 8 months ago (2012-04-05 22:52:30 UTC) #2
yzshen1
On 2012/04/05 22:52:30, brettw wrote: > LGTM. Thanks for fixing my bugs :P Thanks for ...
8 years, 8 months ago (2012-04-05 22:54:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/9949038/1
8 years, 8 months ago (2012-04-06 02:24:05 UTC) #4
commit-bot: I haz the power
8 years, 8 months ago (2012-04-06 04:56:37 UTC) #5
Change committed as 131101

Powered by Google App Engine
This is Rietveld 408576698