Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issue 9949024: Moved WebDataService to ProfileKeyedService (Closed)

Created:
8 years, 8 months ago by GeorgeY
Modified:
8 years, 7 months ago
CC:
chromium-reviews, ncarter (slow), akalin, Raghu Simha, dhollowa+watch_chromium.org, dyu1, tfarina, James Su, Ilya Sherman, tim (not reviewing)
Visibility:
Public.

Description

Moved WebDataService to ProfileKeyedService James: chrome\browser\ui\intents Peter: chrome\browser\ui\search_engines chrome\browser\search_engines Nicolas: chrome\browser\sync Rachel: chrome\browser\profiles and the whole cl original cl: https://chromiumcodereview.appspot.com/9834056/ - needed to re-base on another branch BUG=112234 TEST=unit-tests TBR=jhawkins@chromium.org,pkasting@chromium.org,zea@chromium.org,rlp@chromium.org,isherman@chromium.org

Patch Set 1 #

Patch Set 2 : yet *another* rebase #

Patch Set 3 : fix compile break introduced by rebase #

Patch Set 4 : and... new re-base #

Patch Set 5 : re-base #

Unified diffs Side-by-side diffs Delta from patch set Stats (+412 lines, -314 lines) Patch
M chrome/browser/autocomplete/search_provider_unittest.cc View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete_history_manager.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/autofill/autofill_metrics_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autofill/personal_data_manager.cc View 1 2 17 chunks +53 lines, -42 lines 0 comments Download
M chrome/browser/autofill/personal_data_manager_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/personal_data_manager_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browsing_data_remover.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/importer/profile_writer.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/intents/register_intent_handler_infobar_delegate_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/intents/web_intents_registry_factory.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/intents/web_intents_registry_unittest.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/memory_purger.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/password_store_default_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_factory.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/password_manager/password_store_win_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/password_manager/password_store_x_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 2 3 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/profiles/profile.h View 1 2 3 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/profiles/profile_dependency_manager.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 2 3 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 3 3 chunks +1 line, -23 lines 0 comments Download
M chrome/browser/search_engines/search_provider_install_data.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service.cc View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_factory.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_sync_unittest.cc View 1 2 3 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_test_util.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_unittest.cc View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/signin/token_service.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/signin/token_service_factory.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/signin/token_service_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc View 7 chunks +18 lines, -8 lines 0 comments Download
M chrome/browser/sync/glue/autofill_profile_data_type_controller.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.h View 3 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 3 chunks +14 lines, -8 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 6 chunks +21 lines, -9 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_factory.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/autofill_helper.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/autofill_helper.cc View 5 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/intents/web_intents_model_unittest.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/search_engines/keyword_editor_controller_unittest.cc View 1 2 3 4 chunks +76 lines, -58 lines 0 comments Download
M chrome/browser/webdata/autocomplete_syncable_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
chrome/browser/webdata/web_data_service.h View 1 2 3 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/webdata/web_data_service.cc View 1 2 3 2 chunks +15 lines, -14 lines 0 comments Download
A chrome/browser/webdata/web_data_service_factory.h View 1 1 chunk +43 lines, -0 lines 0 comments Download
A chrome/browser/webdata/web_data_service_factory.cc View 1 1 chunk +57 lines, -0 lines 0 comments Download
M chrome/browser/webdata/web_data_service_unittest.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/base/profile_mock.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/testing_profile.h View 1 2 3 4 chunks +0 lines, -15 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 2 3 4 chunks +0 lines, -31 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/georgey@chromium.org/9949024/2001
8 years, 8 months ago (2012-04-05 21:33:30 UTC) #1
commit-bot: I haz the power
Try job failure for 9949024-2001 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-05 22:03:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/georgey@chromium.org/9949024/7001
8 years, 8 months ago (2012-04-05 22:29:54 UTC) #3
commit-bot: I haz the power
Try job failure for 9949024-7001 (retry) on mac_rel for step "unit_tests". It's a second try, ...
8 years, 8 months ago (2012-04-06 00:40:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/georgey@chromium.org/9949024/7001
8 years, 8 months ago (2012-04-06 00:53:17 UTC) #5
commit-bot: I haz the power
Try job failure for 9949024-7001 (retry) on mac_rel for step "unit_tests". It's a second try, ...
8 years, 8 months ago (2012-04-06 03:03:49 UTC) #6
M-A Ruel
(Fixed Nicolas email address as I was tired of getting mail delivery failure notifications#)
8 years, 8 months ago (2012-04-06 12:03:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/georgey@chromium.org/9949024/7001
8 years, 8 months ago (2012-04-06 12:09:57 UTC) #8
commit-bot: I haz the power
Can't apply patch for file chrome/browser/profiles/profile_dependency_manager.cc. While running patch -p1 --forward --force; patching file chrome/browser/profiles/profile_dependency_manager.cc ...
8 years, 8 months ago (2012-04-06 12:10:11 UTC) #9
GeorgeY
8 years, 8 months ago (2012-04-06 16:55:16 UTC) #10
On 2012/04/06 12:03:26, Marc-Antoine Ruel wrote:
> (Fixed Nicolas email address as I was tired of getting mail delivery failure
> notifications#)

Thanks! Sorry :)

Powered by Google App Engine
This is Rietveld 408576698