webkit/glue/webfileutilities_impl.cc - Issue 9949011: Make FileStream::Seek async and add FileStream::SeekSync for sync operation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/glue/webfileutilities_impl.cc

Issue 9949011: Make FileStream::Seek async and add FileStream::SeekSync for sync operation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed comments + added tests Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/glue/webfileutilities_impl.cc

diff --git a/webkit/glue/webfileutilities_impl.cc b/webkit/glue/webfileutilities_impl.cc

index b7928fd7db5112478c4589f27b80ac8a00ce5c99..a1110e690b99edf228aa85691aa474053a2f9f37 100644

--- a/webkit/glue/webfileutilities_impl.cc

+++ b/webkit/glue/webfileutilities_impl.cc

@@ -128,7 +128,7 @@ long long WebFileUtilitiesImpl::seekFile(base::PlatformFile handle,

if (handle == base::kInvalidPlatformFileValue)

return -1;

net::FileStream file_stream(handle, 0, NULL);

- return file_stream.Seek(static_cast<net::Whence>(origin), offset);

+ return file_stream.SeekSync(static_cast<net::Whence>(origin), offset);

}

bool WebFileUtilitiesImpl::truncateFile(base::PlatformFile handle,

« net/base/test_completion_callback.h ('K') | « webkit/fileapi/file_writer_delegate.cc ('k') | webkit/media/webmediaplayer_impl.cc » ('j') | no next file with comments »