webkit/fileapi/file_system_url_request_job.cc - Issue 9949011: Make FileStream::Seek async and add FileStream::SeekSync for sync operation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/fileapi/file_system_url_request_job.cc

Issue 9949011: Make FileStream::Seek async and add FileStream::SeekSync for sync operation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed comments + added tests Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/fileapi/file_system_url_request_job.cc

diff --git a/webkit/fileapi/file_system_url_request_job.cc b/webkit/fileapi/file_system_url_request_job.cc

index d56f2fd866d616e9cd09d8dbe9cdd02408039a80..18151171f424be03f0a43c3ca7499cb0cad56756 100644

--- a/webkit/fileapi/file_system_url_request_job.cc

+++ b/webkit/fileapi/file_system_url_request_job.cc

@@ -245,7 +245,8 @@ void FileSystemURLRequestJob::DidOpen(base::PlatformFileError error_code,

if (remaining_bytes_ > 0 &&

byte_range_.first_byte_position() != 0 &&

byte_range_.first_byte_position() !=

- stream_->Seek(net::FROM_BEGIN, byte_range_.first_byte_position())) {

+ stream_->SeekSync(net::FROM_BEGIN,

+ byte_range_.first_byte_position())) {

NotifyFailed(net::ERR_REQUEST_RANGE_NOT_SATISFIABLE);

return;

}

« net/base/test_completion_callback.h ('K') | « webkit/blob/blob_url_request_job.cc ('k') | webkit/fileapi/file_writer_delegate.cc » ('j') | no next file with comments »