content/browser/download/base_file.cc - Issue 9949011: Make FileStream::Seek async and add FileStream::SeekSync for sync operation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/base_file.cc

Issue 9949011: Make FileStream::Seek async and add FileStream::SeekSync for sync operation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebased Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/download/base_file.cc

diff --git a/content/browser/download/base_file.cc b/content/browser/download/base_file.cc

index 456454814c1427c9f15f78cc6ae197cb53c121c1..5c27adeb3dd42c9f481e715d5665e0ba4dfd84ac 100644

--- a/content/browser/download/base_file.cc

+++ b/content/browser/download/base_file.cc

@@ -510,7 +510,7 @@ net::Error BaseFile::Open() {

// We may be re-opening the file after rename. Always make sure we're

// writing at the end of the file.

- int64 seek_result = file_stream_->Seek(net::FROM_END, 0);

+ int64 seek_result = file_stream_->SeekSync(net::FROM_END, 0);

if (seek_result < 0)

return ClearStream(LOG_ERROR("Seek", seek_result));

} else {

« no previous file with comments | « no previous file | net/base/completion_callback.h » ('j') | no next file with comments »