Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5024)

Unified Diff: chrome/test/functional/test_clean_exit.py

Issue 9936002: Added code so renderer would cleanly exit. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Added chrome_switches.cc to libcontent_browser.a. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/chrome_render_process_observer.cc ('k') | content/browser/child_process_launcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/functional/test_clean_exit.py
diff --git a/chrome/test/functional/test_clean_exit.py b/chrome/test/functional/test_clean_exit.py
new file mode 100755
index 0000000000000000000000000000000000000000..470305758ca5ddf8b16ceae58385161e87a4a962
--- /dev/null
+++ b/chrome/test/functional/test_clean_exit.py
@@ -0,0 +1,39 @@
+#!/usr/bin/env python
+# Copyright (c) 2012 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import os
+import tempfile
+import unittest
+
+import pyauto_functional
+import pyauto
+
+
+class SimpleTest(pyauto.PyUITest):
+
+ def ExtraChromeFlags(self):
+ """Ensures Chrome is launched with custom flags.
+
+ Returns:
+ A list of extra flags to pass to Chrome when it is launched.
+ """
+ # Extra flag needed by scroll performance tests.
+ fd, self._strace_log = tempfile.mkstemp()
+ os.close(fd)
+ return ['--no-sandbox', '--renderer-clean-exit',
Nirnimesh 2012/04/06 04:34:10 This method should only ever append to the parent'
asharif1 2012/04/06 18:45:58 Done.
+ '--renderer-cmd-prefix=/usr/bin/strace -o %s' % self._strace_log]
+
+
+ def testCleanExit(self):
+ """Ensures the renderer process cleanly exits."""
+ self.NavigateToURL('http://www.google.com')
Nirnimesh 2012/04/06 04:34:10 You don't need to navigate to a live URL. Just use
asharif1 2012/04/06 18:45:58 Done.
+ crash_url = 'about:inducebrowsercrashforrealz'
+ self.NavigateToURL(crash_url)
+ strace_contents = open(self._strace_log).read()
Nirnimesh 2012/04/06 04:34:10 Delete self._strace_log after this?
asharif1 2012/04/06 18:45:58 Done.
+ self.assertTrue("exit_group" in strace_contents)
Nirnimesh 2012/04/06 04:34:10 use ' instead of " for consistency
asharif1 2012/04/06 18:45:58 Done.
+
+
+if __name__ == '__main__':
+ pyauto_functional.Main()
« no previous file with comments | « chrome/renderer/chrome_render_process_observer.cc ('k') | content/browser/child_process_launcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698