Added code so renderer would cleanly exit.

content/renderer/render_thread_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_thread_impl.h"
 
 #include <algorithm>
 #include <limits>
 #include <map>
 #include <vector>
@@ skipping 178 matching lines @@
     // from the IPC channel) are routed to the main message loop but never
     // processed (because that message loop is stuck in V8).
     //
     // One could make the browser SIGKILL the renderers, but that leaves open a
     // large window where a browser failure (or a user, manually terminating
     // the browser because "it's stuck") will leave behind a process eating all
     // the CPU.
     //
     // So, we install a filter on the channel so that we can process this event
     // here and kill the process.
-
-    _exit(0);
+    //
+    // We want to kill this process after giving it 30 seconds to run the exit
+    // handlers. SIGALRM has a default disposition of terminating the
+    // application.
+    if (CommandLine::ForCurrentProcess()->
+        HasSwitch(switches::kRendererCleanExit))

[Markus (顧孟勤), 2012/04/09 23:45:46]

I am sure, I am just confused here. Shouldn't we be looking at the
terminate_child_on_shutdown variable that you set in the other object? Is this
variable ever used anywhere?

[asharif1, 2012/04/10 03:08:00]

As far as I understand, that variable is set in the parent browser process and
is unset in the case the command line flag is given. That causes the parent
process not to send a SIGTERM signal to the renderer.

In addition I need this here so _exit() is not called and the renderer has time
to actually shut down properly and call exit() along with the handlers.

I am not sure whether the renderer process uses the same ChildProcessLauncher
class. If so, I may be able to use it here...

+      alarm(30);
+    else
+      _exit(0);
   }
 };
 #endif  // OS_POSIX
 
 
 void RenderThreadImpl::Init() {
   TRACE_EVENT_BEGIN_ETW("RenderThreadImpl::Init", 0, "");
 
 #if defined(OS_MACOSX) || defined(OS_ANDROID)
   // On Mac and Android, the select popups are rendered by the browser.
@@ skipping 803 matching lines @@
 
 scoped_refptr<base::MessageLoopProxy>
 RenderThreadImpl::GetFileThreadMessageLoopProxy() {
   DCHECK(message_loop() == MessageLoop::current());
   if (!file_thread_.get()) {
     file_thread_.reset(new base::Thread("Renderer::FILE"));
     file_thread_->Start();
   }
   return file_thread_->message_loop_proxy();
 }