Added code so renderer would cleanly exit.

chrome/renderer/chrome_render_process_observer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_render_process_observer.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/message_loop.h"
@@ skipping 127 matching lines @@
       RenderThread::Get()->PreCacheFont(logfont);
       rv = GetFontData(hdc, table, offset, buffer, length);
       RenderThread::Get()->ReleaseCachedFonts();
     }
   }
   return rv;
 }
 #endif  // OS_WIN
 
 #if defined(OS_POSIX)
 class SuicideOnChannelErrorFilter : public IPC::ChannelProxy::MessageFilter {

[jam, 2012/04/09 16:02:37]

I just realized I missed moving this class to content. This belongs in content
and not chrome because we don't want every embedder of content to have to do
this.

if you don't mind, can you move this to
http://code.google.com/searchframe#OAMlx_jo-ck/src/content/renderer/render_th...
?

[asharif1, 2012/04/09 23:26:35]

Separate CL uploaded here: https://chromiumcodereview.appspot.com/10027027/

   void OnChannelError() {
     // On POSIX, at least, one can install an unload handler which loops
     // forever and leave behind a renderer process which eats 100% CPU forever.
     //
     // This is because the terminate signals (ViewMsg_ShouldClose and the error
     // from the IPC channel) are routed to the main message loop but never
     // processed (because that message loop is stuck in V8).
     //
     // One could make the browser SIGKILL the renderers, but that leaves open a
     // large window where a browser failure (or a user, manually terminating
     // the browser because "it's stuck") will leave behind a process eating all
     // the CPU.
     //
     // So, we install a filter on the channel so that we can process this event
     // here and kill the process.
 
-    _exit(0);
+    if (CommandLine::ForCurrentProcess()->
+        HasSwitch(switches::kEnableRendererCleanExit))
+      alarm(30);

[Markus (顧孟勤), 2012/04/06 21:41:59]

I think I mentioned this before. A comment would be great. It's not entirely
obvious to a casual reader that we are relying on the fact that SIGALRM has a
default disposition of terminating the application.

In fact, if we wanted to be thorough, we'd reset things to SIG_DFL.

[asharif1, 2012/04/09 23:26:35]

Done.

+    else
+      _exit(0);
   }
 };
 #endif  // OS_POSIX
 
 }  // namespace
 
 bool ChromeRenderProcessObserver::is_incognito_process_ = false;
 
 ChromeRenderProcessObserver::ChromeRenderProcessObserver(
     chrome::ChromeContentRendererClient* client)
@@ skipping 198 matching lines @@
   if (clear_cache_pending_) {
     clear_cache_pending_ = false;
     WebCache::clear();
   }
 }
 
 const RendererContentSettingRules*
 ChromeRenderProcessObserver::content_setting_rules() const {
   return &content_setting_rules_;
 }