Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 99317: Don't throw an exception for files with only property changes. (Closed)

Created:
11 years, 7 months ago by Mark Larson
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, jam, Nicolas Sylvain
Visibility:
Public.

Description

Don't throw an exception for files with only property changes. R= maruel

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M gcl.py View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Larson
A file with only property changes has the following status xml: <entry path="browser\plugin_process_host.h"> <wc-status props="modified" ...
11 years, 7 months ago (2009-05-02 22:02:40 UTC) #1
Mark Larson
I already had this file open, so I -- added 'missing' for '!' -- alphabetized ...
11 years, 7 months ago (2009-05-02 22:10:10 UTC) #2
M-A Ruel
11 years, 7 months ago (2009-05-03 00:15:01 UTC) #3
lgtm but you'll need to switch your check out first to be able to commit. Note
that I'm moving this code to gclient.py to remove duplication, I'll make sure to
get it right.

Powered by Google App Engine
This is Rietveld 408576698