Making CloseWindow and CloseTab automation API...

Making CloseWindow and CloseTab automation API
synchronous and robust.

Adding automation APIs with corresponding
IPC messages to count and find normal browser
windows.



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15058

[Finnur, 2009-05-01 04:05:49]

LGTM. Minor nits below.

http://codereview.chromium.org/99268/diff/1/11
File chrome/browser/automation/automation_provider.cc (right):

http://codereview.chromium.org/99268/diff/1/11#newcode1362
Line 1362: *handle = browser_tracker_->Add(browser);
Don't you want to NULL handle if no browser was found?

http://codereview.chromium.org/99268/diff/1/9
File chrome/test/automated_ui_tests/automated_ui_test_base.cc (right):

http://codereview.chromium.org/99268/diff/1/9#newcode37
Line 37: LogInfoMessage("get_tab_count_time_out");
nit: add a 'd' after time (timed_out)

http://codereview.chromium.org/99268/diff/1/9#newcode43
Line 43: // Wait until tab is closed
nit: End the comment in a period.

http://codereview.chromium.org/99268/diff/1/5
File chrome/test/automated_ui_tests/automated_ui_test_base.h (right):

http://codereview.chromium.org/99268/diff/1/5#newcode28
Line 28: // Returns true if the tab is closed, false otherwise.
Please document why we never close the last tab of the last window.

http://codereview.chromium.org/99268/diff/1/5#newcode32
Line 32: // Returns true if the window is closed, false otherwise.
Please document why we never close the last window.