Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 99267: Only unset the kWebPluginDelegateProperty property after calling the plugin's... (Closed)

Created:
11 years, 7 months ago by jam
Modified:
9 years, 7 months ago
Reviewers:
ananta
CC:
chromium-reviews_googlegroups.com, vangelis
Visibility:
Public.

Description

Only unset the kWebPluginDelegateProperty property after calling the plugin's windowproc, otherwise if it ends up dispatching another message to itself we'll hit the NOTREACHED at the beginning of the function. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15077

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -25 lines) Patch
M webkit/glue/plugins/webplugin_delegate_impl.cc View 2 chunks +19 lines, -25 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
11 years, 7 months ago (2009-05-01 01:49:59 UTC) #1
ananta
11 years, 7 months ago (2009-05-01 03:56:13 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698