Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 99264: Add a script that runs cov-build, cov-analyze, and... (Closed)

Created:
11 years, 7 months ago by wtc
Modified:
9 years, 7 months ago
Reviewers:
Patrick Johnson
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add a script that runs cov-build, cov-analyze, and cov-commit-defects on a Chromium tree. R=patrick BUG=N/A TEST=N/A Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15831

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 10

Patch Set 3 : Address some review comments #

Patch Set 4 : Add a TODO comment #

Total comments: 9

Patch Set 5 : Upload before checkin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -0 lines) Patch
A tools/coverity/coverity.py View 1 2 3 4 1 chunk +136 lines, -0 lines 0 comments Download
A tools/coverity/coverity.py View 1 2 3 4 1 chunk +136 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
wtc
This is my first Python script.
11 years, 7 months ago (2009-05-01 00:14:35 UTC) #1
Patrick Johnson
Very nice for a first Python script! I mostly just have style nits. http://codereview.chromium.org/99264/diff/4/1001 File ...
11 years, 7 months ago (2009-05-04 16:41:21 UTC) #2
wtc
Patrick, please look at the latest patch set. I added TODO comments for the issues ...
11 years, 7 months ago (2009-05-07 22:28:08 UTC) #3
Patrick Johnson
LGTM http://codereview.chromium.org/99264/diff/3004/4002 File tools/coverity/coverity.py (right): http://codereview.chromium.org/99264/diff/3004/4002#newcode13 Line 13: %comspec% /c ""C:\Program Files\Microsoft Visual Studio 8\VC\vcvarsall.bat" ...
11 years, 7 months ago (2009-05-08 04:47:14 UTC) #4
wtc
11 years, 7 months ago (2009-05-12 18:27:26 UTC) #5
I have checked in this script.  Thanks for the review.

http://codereview.chromium.org/99264/diff/3004/4002
File tools/coverity/coverity.py (right):

http://codereview.chromium.org/99264/diff/3004/4002#newcode68
Line 68: lock_file = os.open(lock_filename,
On 2009/05/08 04:47:14, Patrick Johnson wrote:
> This looks fine to me, but have you verified it works properly?

Yes, I have.

http://codereview.chromium.org/99264/diff/3004/4002#newcode97
Line 97: cmd = '%s\\cov-build.exe --dir %s devenv.com %s\\%s /build %s' % (
On 2009/05/08 04:47:14, Patrick Johnson wrote:
> Maybe make a note that devenv.com is expected to be on the PATH.

I added a comment to note that this script should be run
in a Visual Studio Command Prompt.

Powered by Google App Engine
This is Rietveld 408576698