Issue 99263: Allow Frame.cpp to be unforked....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99263: Allow Frame.cpp to be unforked.... (Closed)

Created:
11 years, 7 months ago by levin

Modified:
9 years, 7 months ago

Reviewers:
Mike Belshe, dglazkov

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Allow Frame.cpp to be unforked. BUG=11263 TEST=Go to any page and then click on a link to navigate to a new page. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15052

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	webkit/glue/webframeloaderclient_impl.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

levin

Here's my attempt to allow unforking Frame.cpp. The primary effect of this change is to ...

11 years, 7 months ago (2009-04-30 23:51:59 UTC) #1

Mike Belshe

lgtm I don't have a better idea - thanks for taking this! Maybe you could ...

11 years, 7 months ago (2009-05-01 00:33:37 UTC) #2

LGTM -- but only if it works. Otherwise, it's LBTM.