More focus fixing.

More focus fixing.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15055

[Avi (use Gerrit), 2009-04-30 23:31:37]

This is basically what the other platforms do.

[rohitrao (ping after 24h), 2009-04-30 23:43:36]

http://codereview.chromium.org/99262/diff/1/2
File chrome/browser/tab_contents/tab_contents_view_mac.mm (right):

http://codereview.chromium.org/99262/diff/1/2#newcode113
Line 113: [[cocoa_view_.get() window] makeFirstResponder:cocoa_view_.get()];
I'm worried that this won't do anything because TabContentsViewCocoa doesn't
acceptFirstResponder.  GetContentNativeView() might be a better choice here.

Although, I'm thinking about moving all of the first responder-ness out of
RWHVCocoa and into TabContentsViewCocoa, which would make this ok again =)

[Avi (use Gerrit), 2009-04-30 23:46:00]

On 2009/04/30 23:43:36, rohitrao wrote:
> I'm worried that this won't do anything because TabContentsViewCocoa doesn't
> acceptFirstResponder.  GetContentNativeView() might be a better choice here.

Good point.

> Although, I'm thinking about moving all of the first responder-ness out of
> RWHVCocoa and into TabContentsViewCocoa, which would make this ok again =)

Let's not do that without lots of discussion. :)

[Avi (use Gerrit), 2009-04-30 23:53:13]

Updated.

[rohitrao (ping after 24h), 2009-04-30 23:58:46]

On 2009/04/30 23:53:13, Avi wrote:
> Updated.

LGTM