Don't show popups before tabs have been added. Instead, prevent the BrowserVi...

chrome/browser/browser.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser.h"
 
 #include "base/command_line.h"
 #include "base/idle_timer.h"
 #include "base/logging.h"
 #include "base/string_util.h"
@@ skipping 2583 matching lines @@
                                      Browser::Type browser_type,
                                      Profile* profile,
                                      bool start_restored) {
   Browser* browser = new Browser(browser_type, profile);
   browser->set_override_bounds(initial_pos);
 
   if (start_restored)
     browser->set_maximized_state(MAXIMIZED_STATE_UNMAXIMIZED);
 
   browser->CreateBrowserWindow();
-  // We need to Show before AddNewContents, otherwise AddNewContents will focus
-  // it (via BrowserView::TabSelectedAt calling RestoreFocus), triggering any
-  // onblur="" handlers.
+  browser->tabstrip_model()->AppendTabContents(new_contents, true);
   browser->window()->Show();
-
-  // TODO(beng): See if this can be made to use
-  //             TabStripModel::AppendTabContents.
-  browser->AddNewContents(source, new_contents, NEW_FOREGROUND_TAB,
-                          gfx::Rect(), true);
 }
 
 GURL Browser::GetHomePage() const {
   if (profile_->GetPrefs()->GetBoolean(prefs::kHomePageIsNewTabPage))
     return GURL(chrome::kChromeUINewTabURL);
   GURL home_page = GURL(URLFixerUpper::FixupURL(
       WideToUTF8(profile_->GetPrefs()->GetString(prefs::kHomePage)),
       std::string()));
   if (!home_page.is_valid())
     return GURL(chrome::kChromeUINewTabURL);
@@ skipping 37 matching lines @@
 
   // We need to register the window position pref.
   std::wstring window_pref(prefs::kBrowserWindowPlacement);
   window_pref.append(L"_");
   window_pref.append(app_name);
   PrefService* prefs = g_browser_process->local_state();
   DCHECK(prefs);
 
   prefs->RegisterDictionaryPref(window_pref.c_str());
 }