Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5249)

Unified Diff: chrome/browser/gtk/find_bar_gtk.cc

Issue 99243: GTK: Directly allocate widgets that are children of GtkFixed. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/gtk/slide_animator_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/find_bar_gtk.cc
===================================================================
--- chrome/browser/gtk/find_bar_gtk.cc (revision 14956)
+++ chrome/browser/gtk/find_bar_gtk.cc (working copy)
@@ -242,7 +242,10 @@
FindBarGtk* findbar) {
// Set the background widget to the size of |fixed|.
if (findbar->border_->allocation.width != allocation->width) {
- gtk_widget_set_size_request(findbar->border_, allocation->width, 1);
+ // Typically it's not a good idea to use this function outside of container
+ // implementations, but GtkFixed doesn't do any sizing on its children so
+ // in this case it's safe.
+ gtk_widget_size_allocate(findbar->border_, allocation);
}
// Reposition |container_|.
« no previous file with comments | « no previous file | chrome/browser/gtk/slide_animator_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698