net/base/prioritized_dispatcher.cc - Issue 9924023: Readability review

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/base/prioritized_dispatcher.cc

Issue 9924023: Readability review (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Responded to Matt's comments. Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "net/base/prioritized_dispatcher.h"	5 #include "net/base/prioritized_dispatcher.h"

6	6

7 #include "base/logging.h"	7 #include "base/logging.h"

8	8

9 namespace net {	9 namespace net {

10	10

(...skipping 81 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
92 if (num_running_jobs_ >= max_running_jobs_[job_priority])	92 if (num_running_jobs_ >= max_running_jobs_[job_priority])

93 return false;	93 return false;

94 Job* job = handle.value();	94 Job* job = handle.value();

95 queue_.Erase(handle);	95 queue_.Erase(handle);

96 ++num_running_jobs_;	96 ++num_running_jobs_;

97 job->Start();	97 job->Start();

98 return true;	98 return true;

99 }	99 }

100	100

101 } // namespace net	101 } // namespace net

102

103

OLD	NEW