Readability review

net/base/priority_queue_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/priority_queue.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace net {
 
 namespace {
@@ skipping 29 matching lines @@
   for (size_t i = 0; i < kNumElements; ++i) {
     EXPECT_EQ(kPriorities[i], pointers[i].priority());
     EXPECT_EQ(static_cast<int>(i), pointers[i].value());
   }
 
   queue.Clear();
   CheckEmpty(&queue);
 }
 
 TEST(PriorityQueueTest, FirstMinOrder) {
   PriorityQueue<int> queue(kNumPriorities);

[stevez, 2012/04/11 16:13:58]

Why not factor out a fixture here with this common setup that you do in every
test.  While it doesn't save much code, it makes it explicit that you're doing
the same setup on each test, so maintainers don't have to scrutinize to see
what's going on.

[szym, 2012/05/17 19:52:01]

Done.

   PriorityQueue<int>::Pointer pointers[kNumElements];
 
   for (size_t i = 0; i < kNumElements; ++i) {
     pointers[i] = queue.Insert(static_cast<int>(i), kPriorities[i]);
   }
 
   for (size_t i = 0; i < kNumElements; ++i) {
     EXPECT_EQ(kNumElements - i, queue.size());
     // Also check Equals.
     EXPECT_TRUE(queue.FirstMin().Equals(pointers[kFirstMinOrder[i]]));
@@ skipping 62 matching lines @@
     EXPECT_EQ(expected_order[i], queue.FirstMin().value());
     queue.Erase(queue.FirstMin());
   }
   CheckEmpty(&queue);
 }
 
 }  // namespace
 
 }  // namespace net
 
+