Issue 99230: Remove COM initialization from renderer...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99230: Remove COM initialization from renderer... (Closed)

Created:
11 years, 7 months ago by cpu_(ooo_6.6-7.5)

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove COM initialization from renderer - Renderers should not use COM TEST= existing tests suffice BUG=11205 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14983

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	chrome/renderer/renderer_main_platform_delegate_win.cc	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

We did use COM before at least for the unicode/font thing. (i forgot the name). ...

11 years, 7 months ago (2009-04-30 18:46:25 UTC) #2

cpu_(ooo_6.6-7.5)

11 years, 7 months ago (2009-04-30 20:09:00 UTC) #3

Not hitting CoCreateInstance in the debugger. Tested some pages with chinese,
russian and vietamese fonts.

I am going to go ahead and commit. I'll send a message in chromium dev in case
there is some special case is not working.

On 2009/04/30 18:46:25, Nicolas Sylvain wrote:
> We did use COM before at least for the unicode/font thing. (i forgot the
name).
> 
> Are you sure everything that uses COM is gone?
> 
> if so, LGTM

Expand Messages | Collapse Messages