Fix the uninstall failures caused by elevated uninstaller.

Fix the uninstall failures caused by elevated uninstaller.

BUG=7178

[kuchhal, 2009-04-30 17:40:11]

The change is a bit messy. But now with all the strange combinations that
installer supports (admin-elevated, admin-nonelevated, non-admin,
non-admin-but-elevated-using-admin-token), I didn't see any better way to do
this.

The changes are:
- If --force-uninstall is used, the uninstall is completely silent and just
tries to do its best.
- If there is cleanup to be done in HKLM, we try to launch a second uninstaller
elevated to do HKLM cleanup.
- Once elevated uninstaller is done, we do HKCU cleanup as well as any files
cleanup (if required).

Tested this on Vista (admin/non-admin), XP (admin/non-admin).

[cpu_(ooo_6.6-7.5), 2009-04-30 18:13:24]

How are we going to test this in an ongoing manner? 

Can we enhance Anantha's installer tests?

On 2009/04/30 17:40:11, kuchhal wrote:
> The change is a bit messy. But now with all the strange combinations that
> installer supports (admin-elevated, admin-nonelevated, non-admin,
> non-admin-but-elevated-using-admin-token), I didn't see any better way to do
> this.
> 
> The changes are:
> - If --force-uninstall is used, the uninstall is completely silent and just
> tries to do its best.
> - If there is cleanup to be done in HKLM, we try to launch a second
uninstaller
> elevated to do HKLM cleanup.
> - Once elevated uninstaller is done, we do HKCU cleanup as well as any files
> cleanup (if required).
> 
> Tested this on Vista (admin/non-admin), XP (admin/non-admin).

[cpu_(ooo_6.6-7.5), 2009-04-30 18:14:17]

btw, is there a bug associated?

On 2009/04/30 18:13:24, cpu wrote:
> How are we going to test this in an ongoing manner? 
> 
> Can we enhance Anantha's installer tests?
> 
> On 2009/04/30 17:40:11, kuchhal wrote:
> > The change is a bit messy. But now with all the strange combinations that
> > installer supports (admin-elevated, admin-nonelevated, non-admin,
> > non-admin-but-elevated-using-admin-token), I didn't see any better way to do
> > this.
> > 
> > The changes are:
> > - If --force-uninstall is used, the uninstall is completely silent and just
> > tries to do its best.
> > - If there is cleanup to be done in HKLM, we try to launch a second
> uninstaller
> > elevated to do HKLM cleanup.
> > - Once elevated uninstaller is done, we do HKCU cleanup as well as any files
> > cleanup (if required).
> > 
> > Tested this on Vista (admin/non-admin), XP (admin/non-admin).

[kuchhal, 2009-04-30 18:20:29]

Yes the bug was in the description - 7178.

We can extend automated installer tests (to a certain extent). For example we
can test that --force-uninstall is doing its job but we still haven't figured
out a good way to respond to elevation dialog from the test program so that part
will have to be tested manually.

[cpu_(ooo_6.6-7.5), 2009-04-30 20:30:55]

LGTM