Issue 99225: Changes the way we calculate hit rects in TabView to reduce...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99225: Changes the way we calculate hit rects in TabView to reduce... (Closed)

Created:
11 years, 7 months ago by rohitrao (ping after 24h)

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Changes the way we calculate hit rects in TabView to reduce overlap between tabs. TEST=Open a few tabs, try clicking on the right half of the close button that's to the left of the selected tab. Committed in http://src.chromium.org/viewvc/chrome?view=rev&revision=14990

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	chrome/browser/cocoa/tab_view.mm	View	1	1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

Comment added to explain where height*1/3 came from.

11 years, 7 months ago (2009-04-30 17:49:09 UTC) #1

LGTM

Expand Messages | Collapse Messages