Issue 99219: Adding ifdef to remove Skia dependency in IPC code for testing.

Issue 99219: Adding ifdef to remove Skia dependency in IPC code for testing. (Closed)

Created:
11 years, 7 months ago by robertshield

Modified:
9 years, 6 months ago

Reviewers:
tommi (sloooow) - chröme

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Adding ifdef to remove Skia dependency in IPC code for testing. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14966

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
M	chrome/common/common.vsprops	View	2	1 chunk	+1 line, -1 line	0 comments	Download
A	chrome/common/extra_defines.vsprops	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/common/ipc_message_utils.cc	View	1 2	3 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

robertshield

On 2009/04/30 15:46:15, robertshield wrote: > This doesn't actually work as such. Please ignore this ...

11 years, 7 months ago (2009-04-30 16:04:33 UTC) #2

robertshield

On 2009/04/30 16:04:33, robertshield wrote: > On 2009/04/30 15:46:15, robertshield wrote: > > > > ...

11 years, 7 months ago (2009-04-30 17:48:24 UTC) #3

amit

Nice! I think there's a scope to refactor other IPC message (like automation) and automation ...

11 years, 7 months ago (2009-04-30 18:02:01 UTC) #4

robertshield

11 years, 7 months ago (2009-04-30 18:45:12 UTC) #6

Thanks for the review!

http://codereview.chromium.org/99219/diff/5/6
File chrome/common/ipc_message_utils.cc (right):

http://codereview.chromium.org/99219/diff/5/6#newcode9
Line 9: #ifndef MIN_TEST_DEPS
On 2009/04/30 18:02:01, amit wrote:
> How about calling this EXCLUDE_SKIA_DEPENDENCIES

Done.

Expand Messages | Collapse Messages