Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4936)

Unified Diff: chrome/browser/bookmarks/bookmark_model.cc

Issue 99217: Implement ID persistence for bookmarks:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/bookmarks/bookmark_model.h ('k') | chrome/browser/bookmarks/bookmark_model_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bookmarks/bookmark_model.cc
===================================================================
--- chrome/browser/bookmarks/bookmark_model.cc (revision 14989)
+++ chrome/browser/bookmarks/bookmark_model.cc (working copy)
@@ -27,6 +27,11 @@
}
+// static
+void BookmarkNode::SetNextId(int next_id) {
+ next_id_ = next_id;
+}
+
const SkBitmap& BookmarkNode::GetFavIcon() {
if (!loaded_favicon_) {
loaded_favicon_ = true;
@@ -36,16 +41,25 @@
}
BookmarkNode::BookmarkNode(BookmarkModel* model, const GURL& url)
- : model_(model),
- id_(next_id_++),
- loaded_favicon_(false),
- favicon_load_handle_(0),
- url_(url),
- type_(!url.is_empty() ? history::StarredEntry::URL :
- history::StarredEntry::BOOKMARK_BAR),
- date_added_(Time::Now()) {
+ : url_(url) {
+ Initialize(model, 0);
}
+BookmarkNode::BookmarkNode(BookmarkModel* model, int id, const GURL& url)
+ : url_(url){
+ Initialize(model, id);
+}
+
+void BookmarkNode::Initialize(BookmarkModel* model, int id) {
+ model_ = model;
+ id_ = id == 0 ? next_id_++ : id;
+ loaded_favicon_ = false;
+ favicon_load_handle_ = 0;
+ type_ = !url_.is_empty() ? history::StarredEntry::URL :
+ history::StarredEntry::BOOKMARK_BAR;
+ date_added_ = Time::Now();
+}
+
void BookmarkNode::Reset(const history::StarredEntry& entry) {
DCHECK(entry.type != history::StarredEntry::URL ||
entry.url == url_);
« no previous file with comments | « chrome/browser/bookmarks/bookmark_model.h ('k') | chrome/browser/bookmarks/bookmark_model_test_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698