net/disk_cache/eviction.cc - Issue 99214: Fix a few broken histograms.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/disk_cache/eviction.cc

Issue 99214: Fix a few broken histograms. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 11 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « net/disk_cache/backend_impl.cc ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // The eviction policy is a very simple pure LRU, so the elements at the end of	5 // The eviction policy is a very simple pure LRU, so the elements at the end of

6 // the list are evicted until kCleanUpMargin free space is available. There is	6 // the list are evicted until kCleanUpMargin free space is available. There is

7 // only one list in use (Rankings::NO_USE), and elements are sent to the front	7 // only one list in use (Rankings::NO_USE), and elements are sent to the front

8 // of the list whenever they are accessed.	8 // of the list whenever they are accessed.

9	9

10 // The new (in-development) eviction policy ads re-use as a factor to evict	10 // The new (in-development) eviction policy ads re-use as a factor to evict

(...skipping 419 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
430 if (last1.get())	430 if (last1.get())

431 CACHE_UMA(AGE, "NoUseAge", header_->experiment,	431 CACHE_UMA(AGE, "NoUseAge", header_->experiment,

432 Time::FromInternalValue(last1.get()->Data()->last_used));	432 Time::FromInternalValue(last1.get()->Data()->last_used));

433 if (last2.get())	433 if (last2.get())

434 CACHE_UMA(AGE, "LowUseAge", header_->experiment,	434 CACHE_UMA(AGE, "LowUseAge", header_->experiment,

435 Time::FromInternalValue(last2.get()->Data()->last_used));	435 Time::FromInternalValue(last2.get()->Data()->last_used));

436 if (last3.get())	436 if (last3.get())

437 CACHE_UMA(AGE, "HighUseAge", header_->experiment,	437 CACHE_UMA(AGE, "HighUseAge", header_->experiment,

438 Time::FromInternalValue(last3.get()->Data()->last_used));	438 Time::FromInternalValue(last3.get()->Data()->last_used));

439 if (last4.get())	439 if (last4.get())

440 CACHE_UMA(AGE, "DeletedUseAge", header_->experiment,	440 CACHE_UMA(AGE, "DeletedAge", header_->experiment,

441 Time::FromInternalValue(last4.get()->Data()->last_used));	441 Time::FromInternalValue(last4.get()->Data()->last_used));

442 }	442 }

443	443

444 } // namespace disk_cache	444 } // namespace disk_cache

OLD	NEW