Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 99213: Measure IPC latency for audio... (Closed)

Created:
11 years, 7 months ago by Alpha Left Google
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, ralphl, fbarchard
Visibility:
Public.

Description

Measure IPC latency for audio With this patch there's totally 5 measurements for audio IPC 1. Total round trip time browser request a packet until it gets a packet 2. Browser receive latency time for a packet to arrive browser from renderer 3. Browser process time time for browser to process the packet 4. Renderer receive latency time for a packet to arrive renderer from browser 5. Renderer process time process time on a packet in renderer They are all using low resolution timer with accuracy of ~1-15ms. Since we have a budget of ~200ms (for now) without clicks, I think the accuracy shouldn't be a big problem, unless for case 1 where we want to measure exact amount of clicks. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15063

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -7 lines) Patch
M chrome/browser/renderer_host/audio_renderer_host.cc View 4 chunks +32 lines, -5 lines 2 comments Download
M chrome/renderer/audio_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/audio_message_filter.cc View 2 chunks +36 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Alpha Left Google
11 years, 7 months ago (2009-04-30 00:41:11 UTC) #1
scherkus (not reviewing)
11 years, 7 months ago (2009-04-30 02:15:10 UTC) #2
LGTM

just curious why we moved away from high res timers... is it because IPC message
logging uses low res timers?

http://codereview.chromium.org/99213/diff/1/4
File chrome/browser/renderer_host/audio_renderer_host.cc (right):

http://codereview.chromium.org/99213/diff/1/4#newcode167
Line 167: #ifdef IPC_MESSAGE_LOG_ENABLED
do you know how we get this defined?

http://codereview.chromium.org/99213/diff/1/4#newcode168
Line 168: base::Time tick_start = base::Time::Now();
curious... why not HighResNow?

Powered by Google App Engine
This is Rietveld 408576698