Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9921018: Added RTF support to pepper API. (Closed)

Created:
8 years, 8 months ago by raymes
Modified:
8 years, 8 months ago
Reviewers:
tony, jam, viettrungluu, dcheng
CC:
chromium-reviews, jam, dcheng, joi+watch-content_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Added RTF support to pepper API. BUG=120435 TEST=out/Release/browser_tests --gtest_filter=*PPAPITest.*Clipboard* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130223

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 1

Patch Set 5 : . #

Total comments: 1

Patch Set 6 : . #

Patch Set 7 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -21 lines) Patch
M content/browser/renderer_host/clipboard_message_filter.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/clipboard_message_filter.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M content/common/clipboard_messages.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/renderer_clipboard_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/renderer_clipboard_client.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ppapi/api/private/ppb_flash_clipboard.idl View 1 chunk +14 lines, -3 lines 0 comments Download
M ppapi/c/private/ppb_flash_clipboard.h View 2 chunks +15 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_flash_clipboard_proxy.cc View 1 2 3 4 5 2 chunks +7 lines, -1 line 0 comments Download
M ppapi/tests/test_flash_clipboard.h View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M ppapi/tests/test_flash_clipboard.cc View 1 2 3 4 5 6 chunks +65 lines, -9 lines 0 comments Download
M webkit/glue/clipboard_client.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppb_flash_clipboard_impl.cc View 1 2 3 4 5 6 4 chunks +24 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/simple_clipboard_impl.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/simple_clipboard_impl.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
raymes
8 years, 8 months ago (2012-03-29 16:55:26 UTC) #1
dcheng
http://codereview.chromium.org/9921018/diff/42/ui/base/clipboard/clipboard_android.cc File ui/base/clipboard/clipboard_android.cc (right): http://codereview.chromium.org/9921018/diff/42/ui/base/clipboard/clipboard_android.cc#newcode17 ui/base/clipboard/clipboard_android.cc:17: const char kRTFFormat[] = "rtf"; Will the earlier patch ...
8 years, 8 months ago (2012-03-29 18:30:57 UTC) #2
raymes
On 2012/03/29 18:30:57, dcheng wrote: > http://codereview.chromium.org/9921018/diff/42/ui/base/clipboard/clipboard_android.cc > File ui/base/clipboard/clipboard_android.cc (right): > > http://codereview.chromium.org/9921018/diff/42/ui/base/clipboard/clipboard_android.cc#newcode17 > ...
8 years, 8 months ago (2012-03-29 18:45:03 UTC) #3
dcheng
lgtm
8 years, 8 months ago (2012-03-29 19:25:57 UTC) #4
viettrungluu
lgtm with small request http://codereview.chromium.org/9921018/diff/3029/ppapi/tests/test_flash_clipboard.cc File ppapi/tests/test_flash_clipboard.cc (right): http://codereview.chromium.org/9921018/diff/3029/ppapi/tests/test_flash_clipboard.cc#newcode121 ppapi/tests/test_flash_clipboard.cc:121: While you're at it, could ...
8 years, 8 months ago (2012-03-29 21:25:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/9921018/11003
8 years, 8 months ago (2012-04-02 18:50:58 UTC) #6
commit-bot: I haz the power
Presubmit check for 9921018-11003 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 8 months ago (2012-04-02 18:51:07 UTC) #7
raymes
+OWNERS tony: webkit/tools and webkit/glue jam: content/*
8 years, 8 months ago (2012-04-02 18:55:34 UTC) #8
tony
LGTM
8 years, 8 months ago (2012-04-02 19:08:21 UTC) #9
jam
lgtm
8 years, 8 months ago (2012-04-02 20:19:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/9921018/11003
8 years, 8 months ago (2012-04-02 20:34:08 UTC) #11
commit-bot: I haz the power
8 years, 8 months ago (2012-04-02 22:10:07 UTC) #12 
Change committed as 130223

Powered by Google App Engine
This is Rietveld 408576698