Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 99182: Rolling back webkit-gyp switch. r14382 (Closed)

Created:
11 years, 7 months ago by bradn
Modified:
9 years, 7 months ago
Reviewers:
sgk
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/
Visibility:
Public.

Description

Rolling back webkit-gyp switch. r14382 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14837

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -150 lines) Patch
M build/all.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/app/chrome_dll.vcproj View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/app/locales/ar.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/bg.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/bn.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/ca.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/cs.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/da.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/de.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/el.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/en-GB.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/en-US.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/es.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/es-419.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/et.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/fi.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/fil.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/fr.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/gu.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/he.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/hi.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/hr.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/hu.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/id.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/it.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/ja.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/kn.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/ko.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/lt.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/lv.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/ml.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/mr.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/nb.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/nl.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/or.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/pl.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/pt-BR.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/pt-PT.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/ro.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/ru.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/sk.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/sl.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/sr.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/sv.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/ta.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/te.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/th.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/tr.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/uk.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/vi.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/zh-CN.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/zh-TW.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.sln View 33 chunks +153 lines, -73 lines 0 comments Download
M chrome/test/browser/browser_tests_dll.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/interactive_ui/interactive_ui.vcproj View 3 chunks +13 lines, -13 lines 0 comments Download
M chrome/test/unit/unittests.vcproj View 4 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
bradn
Rolling back the switch. Learned a bunch, but unlikely to make it stick. TBR=sgk
11 years, 7 months ago (2009-04-29 11:09:22 UTC) #1
sgk
11 years, 7 months ago (2009-04-29 12:46:22 UTC) #2 
rubber-stamp lgtm

> Rolling back webkit-gyp switch. r14382

Been there, done that, the T-shirt takes a while to arrive...  :-)  The
production buildbot slaves definitely introduce a set of new issues for these
conversions...

Powered by Google App Engine
This is Rietveld 408576698