Enhancing profiling data processing code with functionality needed for the Dev Tools Profiler.

tools/profile_view.js

Index: tools/profile_view.js
diff --git a/tools/profile_view.js b/tools/profile_view.js
index 8cffccc7ca2d4edef5a66e7726918347f0f162e1..cd0511f6bae9e619dcf891bffa2ee4546bea4e21 100644
--- a/tools/profile_view.js
+++ b/tools/profile_view.js
@@ -77,6 +77,26 @@ devtools.profiler.ViewBuilder.prototype.buildView = function(
  */
 devtools.profiler.ProfileView = function(head) {
   this.head = head;

[Søren Thygesen Gjesse, 2009/04/29 21:46:22]

Trailing underscores?

[Mikhail Naganov, 2009/04/30 08:06:02]

No. This is for compatibility with WebInspector original objects.

+  this.title = '';
+  this.uid = '';
+  this.heavyProfile = null;
+  this.treeProfile = null;
+  this.flatProfile = null;
+};
+
+
+/**
+ * Updates references between profiles. This is needed for WebKit
+ * ProfileView.
+ */
+devtools.profiler.ProfileView.prototype.updateProfilesRefs = function() {
+  var profileNames = ["treeProfile", "heavyProfile", "flatProfile"];
+  for (var i = 0; i < profileNames.length; ++i) {
+    var destProfile = this[profileNames[i]];
+    for (var j = 0; j < profileNames.length; ++j) {
+      destProfile[profileNames[j]] = this[profileNames[j]];

[Søren Thygesen Gjesse, 2009/04/29 21:46:22]

This means that each profile references itself as well as the other two. Is the
reference to itself required by WebKit ProfileView?

[Mikhail Naganov, 2009/04/30 08:06:02]

Well, it is needed in the version of WebInspector I'm experimenting on. Thanks
to your question, I looked at the current state and found that in
http://trac.webkit.org/changeset/42808 the interface had been changed. So when
I'll update my code, this will be not needed.

+    }
+  }
 };
 
 
@@ -95,6 +115,73 @@ devtools.profiler.ProfileView.prototype.sort = function(sortFunc) {
 
 
 /**
+ * Sorts the profile view by self time, ascending.
+ */
+devtools.profiler.ProfileView.prototype.sortSelfTimeAscending = function() {
+  this.sort(function (node1, node2) {
+      return node1.selfTime - node2.selfTime; });
+};
+
+
+/**
+ * Sorts the profile view by self time, descending.
+ */
+devtools.profiler.ProfileView.prototype.sortSelfTimeDescending = function() {
+  this.sort(function (node1, node2) {
+      return node2.selfTime - node1.selfTime; });
+};
+
+
+/**
+ * Sorts the profile view by total time, ascending.
+ */
+devtools.profiler.ProfileView.prototype.sortTotalTimeAscending = function() {
+  this.sort(function (node1, node2) {
+      return node1.totalTime - node2.totalTime; });
+};
+
+
+/**
+ * Sorts the profile view by total time, descending.
+ */
+devtools.profiler.ProfileView.prototype.sortTotalTimeDescending = function() {
+  this.sort(function (node1, node2) {
+      return node2.totalTime - node1.totalTime; });
+};
+
+
+/**
+ * String comparator compatible with Array.sort requirements.
+ *
+ * @param {string} s1 First string.
+ * @param {string} s2 Second string.
+ */
+devtools.profiler.ProfileView.compareStrings = function(s1, s2) {
+  return s1 < s2 ? -1 : (s1 > s2 ? 1 : 0);
+};
+
+
+/**
+ * Sorts the profile view by function name, ascending.
+ */
+devtools.profiler.ProfileView.prototype.sortFunctionNameAscending = function() {
+  this.sort(function (node1, node2) {
+      return devtools.profiler.ProfileView.compareStrings(
+          node1.functionName, node2.functionName); });
+};
+
+
+/**
+ * Sorts the profile view by function name, descending.
+ */
+devtools.profiler.ProfileView.prototype.sortFunctionNameDescending = function() {
+  this.sort(function (node1, node2) {
+      return devtools.profiler.ProfileView.compareStrings(
+          node2.functionName, node1.functionName); });
+};
+
+
+/**
  * Traverses profile view nodes in preorder.
  *
  * @param {function(devtools.profiler.ProfileView.Node)} f Visitor function.
@@ -125,12 +212,63 @@ devtools.profiler.ProfileView.prototype.traverse = function(f) {
  */
 devtools.profiler.ProfileView.Node = function(
     internalFuncName, totalTime, selfTime, head) {
+  this.callIdentifier = 0;

[Søren Thygesen Gjesse, 2009/04/29 21:46:22]

Trailing underscores?

[Mikhail Naganov, 2009/04/30 08:06:02]

No again. This is for compatibility with WebInspector.

   this.internalFuncName = internalFuncName;
+  this.initFuncInfo();
   this.totalTime = totalTime;
   this.selfTime = selfTime;
   this.head = head;
   this.parent = null;
   this.children = [];
+  this.visible = true;
+};
+
+
+/**
+ * RegEx for stripping V8's prefixes of compiled functions.
+ */
+devtools.profiler.ProfileView.Node.FUNC_NAME_STRIP_RE =
+    /^(?:LazyCompile|Function): (.*)$/;

[Søren Thygesen Gjesse, 2009/04/29 21:46:22]

Maybe we should go and change the logged strings instead of making these part of
the function name...

[Mikhail Naganov, 2009/04/30 08:06:02]

I'm currently thinking on how to better transfer profiler events from V8 to
DevTools. So maybe instead of gluing names in V8 and them parsing them back in
this code, we'll be transferring them in a more structured form.

+
+
+/**
+ * RegEx for extracting script source URL and line number.
+ */
+devtools.profiler.ProfileView.Node.FUNC_NAME_PARSE_RE = /^([^ ]+) (.*):(\d+)$/;
+
+
+/**
+ * RegEx for removing protocol name from URL.
+ */
+devtools.profiler.ProfileView.Node.URL_PARSE_RE = /^(?:http:\/)?.*\/([^/]+)$/;
+
+
+/**
+ * Inits 'functionName', 'url', and 'lineNumber' fields using 'internalFuncName'
+ * field.
+ */
+devtools.profiler.ProfileView.Node.prototype.initFuncInfo = function() {
+  var nodeAlias = devtools.profiler.ProfileView.Node;
+  this.functionName = this.internalFuncName;
+
+  var strippedName = nodeAlias.FUNC_NAME_STRIP_RE.exec(this.functionName);
+  if (strippedName) {
+    this.functionName = strippedName[1];
+  }
+
+  var parsedName = nodeAlias.FUNC_NAME_PARSE_RE.exec(this.functionName);
+  if (parsedName) {
+    this.url = parsedName[2];
+    var parsedUrl = nodeAlias.URL_PARSE_RE.exec(this.url);
+    if (parsedUrl) {
+      this.url = parsedUrl[1];
+    }
+    this.functionName = parsedName[1];
+    this.lineNumber = parsedName[3];
+  } else {
+    this.url = '';
+    this.lineNumber = 0;
+  }
 };