Enhancing profiling data processing code with functionality needed for the Dev Tools Profiler.

Enhancing profiling data processing code with functionality needed for the Dev Tools Profiler.

Details:

 - added properties / functions in view objects needed for WebKit's ProfileView;

 - added ability to count profiles for specific functions.

The tickprocessor functionality does not affected.

Committed: http://code.google.com/p/v8/source/detail?r=1823

[Søren Thygesen Gjesse, 2009-04-29 21:46:22]

LGTM

http://codereview.chromium.org/99181/diff/1/4
File tools/profile_view.js (right):

http://codereview.chromium.org/99181/diff/1/4#newcode79
Line 79: this.head = head;
Trailing underscores?

http://codereview.chromium.org/99181/diff/1/4#newcode97
Line 97: destProfile[profileNames[j]] = this[profileNames[j]];
This means that each profile references itself as well as the other two. Is the
reference to itself required by WebKit ProfileView?

http://codereview.chromium.org/99181/diff/1/4#newcode215
Line 215: this.callIdentifier = 0;
Trailing underscores?

http://codereview.chromium.org/99181/diff/1/4#newcode231
Line 231: /^(?:LazyCompile|Function): (.*)$/;
Maybe we should go and change the logged strings instead of making these part of
the function name...

[Mikhail Naganov, 2009-04-30 08:06:02]

Thanks for reviewing. This code is actually a moving target because WebInspector
is evolving too, and the transport of profiler messages isn't finalized yet.

http://codereview.chromium.org/99181/diff/1/4
File tools/profile_view.js (right):

http://codereview.chromium.org/99181/diff/1/4#newcode79
Line 79: this.head = head;
On 2009/04/29 21:46:22, Søren Gjesse wrote:
> Trailing underscores?

No. This is for compatibility with WebInspector original objects.

http://codereview.chromium.org/99181/diff/1/4#newcode97
Line 97: destProfile[profileNames[j]] = this[profileNames[j]];
On 2009/04/29 21:46:22, Søren Gjesse wrote:
> This means that each profile references itself as well as the other two. Is
the
> reference to itself required by WebKit ProfileView?

Well, it is needed in the version of WebInspector I'm experimenting on. Thanks
to your question, I looked at the current state and found that in
http://trac.webkit.org/changeset/42808 the interface had been changed. So when
I'll update my code, this will be not needed.

http://codereview.chromium.org/99181/diff/1/4#newcode215
Line 215: this.callIdentifier = 0;
On 2009/04/29 21:46:22, Søren Gjesse wrote:
> Trailing underscores?

No again. This is for compatibility with WebInspector.

http://codereview.chromium.org/99181/diff/1/4#newcode231
Line 231: /^(?:LazyCompile|Function): (.*)$/;
On 2009/04/29 21:46:22, Søren Gjesse wrote:
> Maybe we should go and change the logged strings instead of making these part
of
> the function name...

I'm currently thinking on how to better transfer profiler events from V8 to
DevTools. So maybe instead of gluing names in V8 and them parsing them back in
this code, we'll be transferring them in a more structured form.