content/shell/shell_javascript_dialog_creator.h - Issue 9918013: Add JavaScript dialogs functionality to content_shell on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/shell_javascript_dialog_creator.h

Issue 9918013: Add JavaScript dialogs functionality to content_shell on Windows (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: style fix 4 Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/shell_javascript_dialog_creator.h

diff --git a/content/shell/shell_javascript_dialog_creator.h b/content/shell/shell_javascript_dialog_creator.h

index 88e5db653d2f9bd30a950197ad5ee5de514620f1..7a998371f40ada47007973c96b41562c9826238a 100644

--- a/content/shell/shell_javascript_dialog_creator.h

+++ b/content/shell/shell_javascript_dialog_creator.h

@@ -42,7 +42,7 @@ class ShellJavaScriptDialogCreator : public JavaScriptDialogCreator {

void DialogClosed(ShellJavaScriptDialog* dialog);

private:

-#if defined(OS_MACOSX)

+#if defined(OS_MACOSX) || defined(OS_WIN)

// The dialog being shown. No queueing.

scoped_ptr<ShellJavaScriptDialog> dialog_;

#else

« content/shell/shell_javascript_dialog.h ('K') | « content/shell/shell_javascript_dialog.h ('k') | content/shell/shell_javascript_dialog_creator.cc » ('j') | no next file with comments »