Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: chrome/renderer/extensions/extension_dispatcher.cc

Issue 9918006: Split SchemaGeneratedBindings up into smaller, more targetted native handlers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/extension_dispatcher.cc
diff --git a/chrome/renderer/extensions/extension_dispatcher.cc b/chrome/renderer/extensions/extension_dispatcher.cc
index 9966e9f87e5e65889ff3d25bf5f971186c78a34b..54ca885a8d930fe2c042503128a9ef97dc8716a2 100644
--- a/chrome/renderer/extensions/extension_dispatcher.cc
+++ b/chrome/renderer/extensions/extension_dispatcher.cc
@@ -16,6 +16,7 @@
#include "chrome/common/extensions/extension_permission_set.h"
#include "chrome/common/url_constants.h"
#include "chrome/renderer/chrome_render_process_observer.h"
+#include "chrome/renderer/extensions/api_definitions_natives.h"
#include "chrome/renderer/extensions/app_bindings.h"
#include "chrome/renderer/extensions/chrome_v8_context.h"
#include "chrome/renderer/extensions/chrome_v8_extension.h"
@@ -31,7 +32,8 @@
#include "chrome/renderer/extensions/miscellaneous_bindings.h"
#include "chrome/renderer/extensions/page_actions_custom_bindings.h"
#include "chrome/renderer/extensions/page_capture_custom_bindings.h"
-#include "chrome/renderer/extensions/schema_generated_bindings.h"
+#include "chrome/renderer/extensions/send_request_natives.h"
+#include "chrome/renderer/extensions/set_icon_natives.h"
#include "chrome/renderer/extensions/tabs_custom_bindings.h"
#include "chrome/renderer/extensions/tts_custom_bindings.h"
#include "chrome/renderer/extensions/user_script_slave.h"
@@ -65,7 +67,9 @@ using extensions::I18NCustomBindings;
using extensions::MiscellaneousBindings;
using extensions::PageActionsCustomBindings;
using extensions::PageCaptureCustomBindings;
-using extensions::SchemaGeneratedBindings;
+using extensions::ApiDefinitionsNatives;
+using extensions::SendRequestNatives;
+using extensions::SetIconNatives;
not at google - send to devlin 2012/03/30 03:23:18 :sort
koz (OOO until 15th September) 2012/04/03 00:15:27 Done.
using extensions::TTSCustomBindings;
using extensions::TabsCustomBindings;
using extensions::WebRequestCustomBindings;
@@ -362,9 +366,14 @@ void ExtensionDispatcher::RegisterNativeHandlers(ModuleSystem* module_system,
scoped_ptr<NativeHandler>(EventBindings::Get(this)));
module_system->RegisterNativeHandler("miscellaneous_bindings",
scoped_ptr<NativeHandler>(MiscellaneousBindings::Get(this)));
- module_system->RegisterNativeHandler("schema_generated_bindings",
+ module_system->RegisterNativeHandler("apiDefinitions",
+ scoped_ptr<NativeHandler>(new ApiDefinitionsNatives(this)));
+ module_system->RegisterNativeHandler("sendRequest",
scoped_ptr<NativeHandler>(
- new SchemaGeneratedBindings(this, request_sender_.get())));
+ new SendRequestNatives(this, request_sender_.get())));
+ module_system->RegisterNativeHandler("setIcon",
+ scoped_ptr<NativeHandler>(
+ new SetIconNatives(this, request_sender_.get())));
// Custom bindings.
module_system->RegisterNativeHandler("app",

Powered by Google App Engine
This is Rietveld 408576698