chrome/renderer/resources/extensions/send_request.js - Issue 9918006: Split SchemaGeneratedBindings up into smaller, more targetted native handlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/send_request.js

Issue 9918006: Split SchemaGeneratedBindings up into smaller, more targetted native handlers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/schema_generated_bindings.js ('k') | chrome/renderer/resources/extensions/set_icon.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/send_request.js

diff --git a/chrome/renderer/resources/extensions/send_request.js b/chrome/renderer/resources/extensions/send_request.js

index 151389e2244a8df95b022bffbe2a40a5a7fa45e4..fff9c90385577be85f00d53b8f3fe4d9b4ce8da3 100644

--- a/chrome/renderer/resources/extensions/send_request.js

+++ b/chrome/renderer/resources/extensions/send_request.js

@@ -3,9 +3,7 @@

// found in the LICENSE file.

var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();

-var sgb = requireNative('schema_generated_bindings');

-var GetNextRequestId = sgb.GetNextRequestId;

-var StartRequest = sgb.StartRequest;

+var natives = requireNative('sendRequest');

// Callback handling.

var requests = [];

@@ -112,9 +110,9 @@ function sendRequest(functionName, args, argSchemas, opt_args) {

var sargs = opt_args.noStringify ?

request.args : chromeHidden.JSON.stringify(request.args);

- var nativeFunction = opt_args.nativeFunction || StartRequest;

+ var nativeFunction = opt_args.nativeFunction || natives.StartRequest;

- var requestId = GetNextRequestId();

+ var requestId = natives.GetNextRequestId();

request.id = requestId;

requests[requestId] = request;

var hasCallback =