Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Unified Diff: chrome/renderer/extensions/schema_generated_bindings.h

Issue 9918006: Split SchemaGeneratedBindings up into smaller, more targetted native handlers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/schema_generated_bindings.h
diff --git a/chrome/renderer/extensions/schema_generated_bindings.h b/chrome/renderer/extensions/schema_generated_bindings.h
deleted file mode 100644
index 8fbcdaff850284d7a67dea98c5a6a22b3b40be32..0000000000000000000000000000000000000000
--- a/chrome/renderer/extensions/schema_generated_bindings.h
+++ /dev/null
@@ -1,67 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_RENDERER_EXTENSIONS_SCHEMA_GENERATED_BINDINGS_H_
-#define CHROME_RENDERER_EXTENSIONS_SCHEMA_GENERATED_BINDINGS_H_
-#pragma once
-
-#include <string>
-
-#include "chrome/renderer/extensions/chrome_v8_extension.h"
-
-class ExtensionDispatcher;
-class ExtensionRequestSender;
-class ChromeV8ContextSet;
-class ChromeV8Extension;
-
-namespace base {
-class ListValue;
-class Value;
-}
-
-namespace v8 {
-class Extension;
-}
-
-namespace extensions {
-
-// Generates JavaScript bindings for the extension system from the JSON
-// declarations in chrome/common/extensions/api/.
-// TODO(koz): Split this up so that GetNextRequestId/StartRequest and
-// SetIconCommon are in separate classes.
-class SchemaGeneratedBindings : public ChromeV8Extension {
- public:
- explicit SchemaGeneratedBindings(ExtensionDispatcher* extension_dispatcher,
- ExtensionRequestSender* request_sender);
-
- private:
- v8::Handle<v8::Value> GetExtensionAPIDefinition(const v8::Arguments& args);
- v8::Handle<v8::Value> GetNextRequestId(const v8::Arguments& args);
-
- // Common code for starting an API request to the browser. |value_args|
- // contains the request's arguments.
- // Steals value_args contents for efficiency.
- v8::Handle<v8::Value> StartRequestCommon(const v8::Arguments& args,
- base::ListValue* value_args);
-
- // Starts an API request to the browser, with an optional callback. The
- // callback will be dispatched to EventBindings::HandleResponse.
- v8::Handle<v8::Value> StartRequest(const v8::Arguments& args);
-
- bool ConvertImageDataToBitmapValue(const v8::Arguments& args,
- base::Value** bitmap_value);
-
- // A special request for setting the extension action icon. This function
- // accepts a canvas ImageData object, so it needs to do extra processing
- // before sending the request to the browser.
- v8::Handle<v8::Value> SetIconCommon(const v8::Arguments& args);
-
- ExtensionRequestSender* request_sender_;
-
- DISALLOW_COPY_AND_ASSIGN(SchemaGeneratedBindings);
-};
-
-} // namespace extensions
-
-#endif // CHROME_RENDERER_EXTENSIONS_SCHEMA_GENERATED_BINDINGS_H_
« no previous file with comments | « chrome/renderer/extensions/extension_helper.cc ('k') | chrome/renderer/extensions/schema_generated_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698