Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Side by Side Diff: chrome/renderer/resources/extensions/send_request.js

Issue 9918006: Split SchemaGeneratedBindings up into smaller, more targetted native handlers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 var chromeHidden = requireNative('chrome_hidden').GetChromeHidden(); 5 var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
6 var sgb = requireNative('schema_generated_bindings'); 6 var natives = requireNative('sendRequest');
7 var GetNextRequestId = sgb.GetNextRequestId; 7 var GetNextRequestId = natives.GetNextRequestId;
8 var StartRequest = sgb.StartRequest; 8 var StartRequest = natives.StartRequest;
not at google - send to devlin 2012/03/30 03:23:18 i reckon a bit cleaner to just require this as "se
koz (OOO until 15th September) 2012/04/03 00:15:27 Cool, but as sendRequest() is already the name of
9 9
10 // Callback handling. 10 // Callback handling.
11 var requests = []; 11 var requests = [];
12 chromeHidden.handleResponse = function(requestId, name, 12 chromeHidden.handleResponse = function(requestId, name,
13 success, response, error) { 13 success, response, error) {
14 try { 14 try {
15 var request = requests[requestId]; 15 var request = requests[requestId];
16 if (success) { 16 if (success) {
17 delete chrome.extension.lastError; 17 delete chrome.extension.lastError;
18 } else { 18 } else {
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 var requestId = GetNextRequestId(); 117 var requestId = GetNextRequestId();
118 request.id = requestId; 118 request.id = requestId;
119 requests[requestId] = request; 119 requests[requestId] = request;
120 var hasCallback = 120 var hasCallback =
121 (request.callback || opt_args.customCallback) ? true : false; 121 (request.callback || opt_args.customCallback) ? true : false;
122 return nativeFunction(functionName, sargs, requestId, hasCallback, 122 return nativeFunction(functionName, sargs, requestId, hasCallback,
123 opt_args.forIOThread); 123 opt_args.forIOThread);
124 } 124 }
125 125
126 exports.sendRequest = sendRequest; 126 exports.sendRequest = sendRequest;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698