Artificially increase the ref count on WebCore strings that we use as...

Artificially increase the ref count on WebCore strings that we use as
external V8 strings.

We seem to be occasionally losing the data for our external strings.
The current hypothesis is that there is a reference counting bug in
WebCore somewhere which is leading to premature deletion of the string
data.  This change is an attempt to verify that this is in fact the
case.  By artificially increasing the ref count on the strings, we
should reduce the likelihood of accidental deletion because of ref
counting being slightly off.  If we can confirm that this removes most
of the crashes, we know that the problem is WebCore ref counting
related.

BUG=9746
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14838

[Kasper Lund, 2009-04-29 08:46:05]

LGTM.

http://codereview.chromium.org/99174/diff/1/2
File webkit/port/bindings/v8/v8_binding.cpp (right):

http://codereview.chromium.org/99174/diff/1/2#newcode32
Line 32: for (int i = 0; i < 5; i++) {
I think should introduce a named constant for the 5. Something like
kArtificialRefs.

http://codereview.chromium.org/99174/diff/1/2#newcode42
Line 42: for (int i = 0; i < 5; i++) {
5 -> kXxx.

[Mads Ager (chromium), 2009-04-29 08:59:50]

On 2009/04/29 08:46:05, Kasper Lund wrote:
> LGTM.
> 
> http://codereview.chromium.org/99174/diff/1/2
> File webkit/port/bindings/v8/v8_binding.cpp (right):
> 
> http://codereview.chromium.org/99174/diff/1/2#newcode32
> Line 32: for (int i = 0; i < 5; i++) {
> I think should introduce a named constant for the 5. Something like
> kArtificialRefs.

Yes, we should.  Done.