Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 99173: Switching webkit over to gyp on windows. (Closed)

Created:
11 years, 7 months ago by bradn
Modified:
9 years, 7 months ago
Reviewers:
sgk
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/
Visibility:
Public.

Description

Switching webkit over to gyp on windows. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14832

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -1757 lines) Patch
M build/all.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/app/chrome_dll.vcproj View 2 chunks +2 lines, -2 lines 1 comment Download
M chrome/app/locales/ar.vcproj View 1 chunk +1 line, -1 line 1 comment Download
M chrome/app/locales/bg.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/bn.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/ca.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/cs.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/da.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/de.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/el.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/en-GB.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/en-US.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/es.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/es-419.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/et.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/fi.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/fil.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/fr.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/gu.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/he.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/hi.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/hr.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/hu.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/id.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/it.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/ja.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/kn.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/ko.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/lt.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/lv.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/ml.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/mr.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/nb.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/nl.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/or.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/pl.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/pt-BR.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/pt-PT.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/ro.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/ru.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/sk.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/sl.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/sr.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/sv.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/ta.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/te.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/th.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/tr.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/uk.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/vi.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/zh-CN.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/locales/zh-TW.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.sln View 33 chunks +72 lines, -153 lines 1 comment Download
M chrome/test/browser/browser_tests_dll.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/interactive_ui/interactive_ui.vcproj View 3 chunks +13 lines, -13 lines 0 comments Download
M chrome/test/unit/unittests.vcproj View 4 chunks +9 lines, -9 lines 0 comments Download
D webkit/default_plugin/default_plugin.vcproj View 1 chunk +0 lines, -187 lines 0 comments Download
D webkit/tools/test_shell/test_shell.vcproj View 1 chunk +0 lines, -359 lines 0 comments Download
D webkit/tools/test_shell/test_shell_tests.vcproj View 1 chunk +0 lines, -465 lines 0 comments Download
D webkit/webkit.sln View 1 chunk +0 lines, -516 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
bradn
TBR=sgk
11 years, 7 months ago (2009-04-29 08:01:54 UTC) #1
sgk
11 years, 7 months ago (2009-04-29 12:34:52 UTC) #2
ex-post-lgtm, some comments on things that might be worth some investigation for
the next run

http://codereview.chromium.org/99173/diff/1/59
File chrome/app/chrome_dll.vcproj (left):

http://codereview.chromium.org/99173/diff/1/59#oldcode59
Line 59: AdditionalDependencies="$(OutDir)\obj\tcmalloc\libcmt.lib"
Hmm.  Seems like this should already be installed in lib\ with the other
libraries.  I'll talk to mbelshe about changing this in a separate CL so it
doesn't have to be another moving part in the middle of the webkit conversion.

http://codereview.chromium.org/99173/diff/1/48
File chrome/app/locales/ar.vcproj (right):

http://codereview.chromium.org/99173/diff/1/48#newcode151
Line 151:
RelativePath="$(OutDir)\obj\global_intermediate\webkit\webkit_strings_ar.rc"
Hmm again.  I see why this is necessary, but having to coordinate these changes
in the checked-in .vcproj files seems like additional complication.  Maybe that
argues for trying to convert webkit+chrome together.  Let's discuss pros+cons
tomorrow.

http://codereview.chromium.org/99173/diff/1/60
File chrome/chrome.sln (left):

http://codereview.chromium.org/99173/diff/1/60#oldcode41
Line 41: {1444235E-0E97-4C80-A73E-EE73F3706C32} =
{1444235E-0E97-4C80-A73E-EE73F3706C32}
Did you trace back through the IDS to identify what these removed dependencies
are?  They may be unnecessary in gyp (cargo cult) or may be something we need to
add for windows?

Powered by Google App Engine
This is Rietveld 408576698