Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Issue 99172: Part 1 of sample sprucing. (Closed)

Created:
11 years, 7 months ago by Aaron Boodman
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Part 1 of sample sprucing. Also, change chromium_extension.py to generate a random ID if the manifest doesn't have one. * Create a test/data/extensions/samples directory and add Reader and Gmail samples to it. * Minor fixes to buildbot sample to fit better visually. * Minor fixes to bookmarks sample to use new button styles. * Workaround for bug in bookmark sample where extension APIs do not load the first time. * Move Resizer extension into samples/. * Fix TabsAPI sample to not use old deprecated manifest properties anymore. Part 2 will move the remaining samples into samples/ (don't want to do that at the same time because git-cl doesn't know how to tell Rietveld about moves and it would be confusing to review).

Patch Set 1 #

Patch Set 2 : Added buildbot.crx, since that seems like something people might want to install. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+653 lines, -102 lines) Patch
M chrome/test/data/extensions/bookmarks/bookmark_api.html View 2 chunks +5 lines, -28 lines 0 comments Download
M chrome/test/data/extensions/bookmarks/bookmark_view.html View 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/bookmarks/extensions_toolstrip.css View 1 chunk +89 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/buildbot/buildbot.html View 2 chunks +15 lines, -31 lines 0 comments Download
A chrome/test/data/extensions/buildbot/extensions_toolstrip.css View 1 chunk +89 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/buildbot/manifest.json View 1 chunk +9 lines, -6 lines 0 comments Download
A chrome/test/data/extensions/samples/buildbot.crx View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/extensions/samples/gmail.crx View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/extensions/samples/gmail/extensions_toolstrip.css View 1 chunk +89 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/samples/gmail/gmail.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/extensions/samples/gmail/gmail_checker.html View 1 chunk +89 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/samples/gmail/manifest.json View 1 chunk +13 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/samples/gmail/styles.css View 1 chunk +16 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/samples/resizer/manifest.json View 1 chunk +6 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/samples/resizer/resizer.html View 1 chunk +33 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/samples/subscribe.crx View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/extensions/samples/subscribe/extensions_toolstrip.css View 1 chunk +89 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/samples/subscribe/feed_finder.js View 1 chunk +19 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/samples/subscribe/icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/extensions/samples/subscribe/icon_disabled.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/extensions/samples/subscribe/icon_subscribed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/extensions/samples/subscribe/manifest.json View 1 chunk +22 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/samples/subscribe/toolstrip.html View 1 chunk +53 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/test/Resizer/manifest.json View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/test/data/extensions/test/Resizer/resizer.html View 1 chunk +0 lines, -33 lines 0 comments Download
M chrome/test/data/extensions/test/TabsAPI/1/manifest.json View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/tools/extensions/chromium_extension.py View 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Aaron Boodman
11 years, 7 months ago (2009-04-29 06:22:57 UTC) #1
Erik does not do reviews
11 years, 7 months ago (2009-04-29 15:24:30 UTC) #2
LGTM

one question:
Why check in the crx files?  We could add a build rule to generate them.  It
seems like this way, they'll always be out of date as people forget to update
them or the format changes.

Powered by Google App Engine
This is Rietveld 408576698