Issue 99168: Replace window.external with a v8::extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99168: Replace window.external with a v8::extension. (Closed)

Created:
11 years, 8 months ago by Mike Belshe

Modified:
9 years, 5 months ago

Reviewers:
Mark Larson, asargent, abarth-chromium

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Replace window.external with a v8::extension. BUG=http://crbug.com/10957 TEST=Verify that the AddSearchProvider logic still works. This dates back to an old bug http://b/1069781 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15056

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -79 lines)			Patch
M	chrome/chrome.gyp	View	3	1 chunk	+2 lines, -2 lines	0 comments	Download
A	chrome/renderer/external_extension.h	View	1 2 3	1 chunk	+21 lines, -0 lines	0 comments	Download
A	chrome/renderer/external_extension.cc	View	1 2 3	1 chunk	+61 lines, -0 lines	0 comments	Download
D	chrome/renderer/external_js_object.h	View		1 chunk	+0 lines, -41 lines	0 comments	Download
D	chrome/renderer/external_js_object.cc	View		1 chunk	+0 lines, -23 lines	0 comments	Download
M	chrome/renderer/render_thread.cc	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/renderer/render_view.h	View	1 2 3 4	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/renderer/renderer.vcproj	View	1 2 3 4	1 chunk	+3 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mike Belshe

Hoping to land this security fix fairly quickly. Avoiding use of the CppBoundObject. More testing ...

11 years, 7 months ago (2009-04-29 19:48:01 UTC) #1

abarth-chromium

I don't know much about how this stuff works, but this looks reasonable to me.

11 years, 7 months ago (2009-04-29 19:53:04 UTC) #2

asargent_no_longer_on_chrome

LGTM. Should we also get rid of external_js_object.{h,cc}?

11 years, 7 months ago (2009-04-29 21:33:14 UTC) #3

Mark Larson

11 years, 7 months ago (2009-05-01 06:54:32 UTC) #4

This hasn't landed on trunk yet. I'm going to patch it into 2.0 anyway, but I'd
like to see it land on trunk in case that uncovers some unusual test/perf
regression.

Expand Messages | Collapse Messages