Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4158)

Unified Diff: chrome/browser/gtk/tab_contents_container_gtk.h

Issue 99166: Linux findbar improvements:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/gtk/infobar_gtk.cc ('k') | chrome/browser/gtk/tab_contents_container_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/tab_contents_container_gtk.h
===================================================================
--- chrome/browser/gtk/tab_contents_container_gtk.h (revision 14854)
+++ chrome/browser/gtk/tab_contents_container_gtk.h (working copy)
@@ -10,6 +10,7 @@
#include "base/basictypes.h"
#include "chrome/common/notification_observer.h"
+class FindBarGtk;
class RenderViewHost;
class TabContents;
@@ -21,9 +22,6 @@
// Inserts our GtkWidget* hierarchy into a GtkBox managed by our owner.
void AddContainerToBox(GtkWidget* widget);
- // Add the findbar to the top of the tab contents container.
- void AddFindBar(GtkWidget* widget);
-
// Make the specified tab visible.
void SetTabContents(TabContents* tab_contents);
TabContents* GetTabContents() const { return tab_contents_; }
@@ -33,6 +31,8 @@
const NotificationSource& source,
const NotificationDetails& details);
+ void set_find_bar(FindBarGtk* findbar) { findbar_ = findbar; }
+
private:
// Add or remove observers for events that we care about.
void AddObservers();
@@ -48,11 +48,6 @@
// get notified.
void TabContentsDestroyed(TabContents* contents);
- // Called when |fixed_| changes sizes. Used to position the findbar.
- static void OnSizeAllocate(GtkWidget* fixed,
- GtkAllocation* allocation,
- TabContentsContainerGtk* contents_container);
-
// The currently visible TabContents.
TabContents* tab_contents_;
@@ -61,12 +56,10 @@
// vbox_.
GtkWidget* vbox_;
- // This GtkFixed widget helps us position the find bar.
- GtkWidget* fixed_;
+ // We have to make sure we are always underneath the findbar, hence this
+ // pointer.
+ FindBarGtk* findbar_;
- // The findbar widget. We do not own it.
- GtkWidget* findbar_;
-
DISALLOW_COPY_AND_ASSIGN(TabContentsContainerGtk);
};
« no previous file with comments | « chrome/browser/gtk/infobar_gtk.cc ('k') | chrome/browser/gtk/tab_contents_container_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698