Issue 99165: Add two new master preferences.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99165: Add two new master preferences. (Closed)

Created:
11 years, 8 months ago by kuchhal

Modified:
9 years, 7 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Add two new master preferences (import_bookmarks and make_default_browser_for_user). make_default_browser_for_user will make Chrome default on the first run of Chrome instead of installer doing it. This will allow Chrome to import user profile data from current default browser, before making Chrome default. BUG=9708, 10912

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -14 lines)			Patch
M	chrome/browser/first_run.cc	View	3 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/installer/util/google_chrome_distribution_unittest.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/installer/util/master_preferences.h	View	2 chunks	+21 lines, -13 lines	0 comments	Download
M	chrome/installer/util/master_preferences.cc	View	2 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

11 years, 7 months ago (2009-04-30 20:32:55 UTC) #2

LGTM

Note that importing bookmarks might crash if importing from toolbar. In general
first-run import is somewhat broken.


On 2009/04/29 00:47:31, kuchhal wrote:
>

Expand Messages | Collapse Messages