Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Unified Diff: media/filters/ffmpeg_audio_decoder.cc

Issue 99160: Clean up FFmpeg media formats and switch to using av_get_bits_per_sample_format(). (Closed)
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/ffmpeg_audio_decoder.cc
diff --git a/media/filters/ffmpeg_audio_decoder.cc b/media/filters/ffmpeg_audio_decoder.cc
index 914a8ed844d5f4092c808915cb336395f9bf3605..019bc15a4b08ac05d83fa6c9d9a385df55b7b425 100644
--- a/media/filters/ffmpeg_audio_decoder.cc
+++ b/media/filters/ffmpeg_audio_decoder.cc
@@ -23,16 +23,9 @@ FFmpegAudioDecoder::~FFmpegAudioDecoder() {
// static
bool FFmpegAudioDecoder::IsMediaFormatSupported(const MediaFormat& format) {
- int channels, sample_bits, sample_rate;
std::string mime_type;
- if (format.GetAsInteger(MediaFormat::kChannels, &channels) &&
- format.GetAsInteger(MediaFormat::kSampleBits, &sample_bits) &&
- format.GetAsInteger(MediaFormat::kSampleRate, &sample_rate) &&
- format.GetAsString(MediaFormat::kMimeType, &mime_type) &&
- mime_type::kFFmpegAudio == mime_type) {
- return true;
- }
- return false;
+ return format.GetAsString(MediaFormat::kMimeType, &mime_type) &&
+ mime_type::kFFmpegAudio == mime_type;
}
bool FFmpegAudioDecoder::OnInitialize(DemuxerStream* demuxer_stream) {
@@ -50,7 +43,7 @@ bool FFmpegAudioDecoder::OnInitialize(DemuxerStream* demuxer_stream) {
codec_context_ = ffmpeg_demuxer_stream->av_stream()->codec;
media_format_.SetAsInteger(MediaFormat::kChannels, codec_context_->channels);
media_format_.SetAsInteger(MediaFormat::kSampleBits,
- codec_context_->bits_per_coded_sample);
+ av_get_bits_per_sample_format(codec_context_->sample_fmt));
media_format_.SetAsInteger(MediaFormat::kSampleRate,
codec_context_->sample_rate);
media_format_.SetAsString(MediaFormat::kMimeType,

Powered by Google App Engine
This is Rietveld 408576698