Clean up FFmpeg media formats and switch to using av_get_bits_per_sample_format().

Clean up FFmpeg media formats and switch to using av_get_bits_per_sample_format().

Before we were relying on codecs setting bits_per_raw_sample, which turns out isn't a valid assumption at all (i.e., vorbis).  However, codecs always set the sample format so we can use the FFmpeg utility function av_get_bits_per_sample_format() to convert the SampleFormat enum to an integer number of bits.

[scherkus (not reviewing), 2009-04-28 23:21:37]

Ignore the chrome.sln change... got included by accident.

ralphl: bulk of the review is on you
ajwong: changes to media_posix.cc (but feel free to check out the rest of the
CL)

[awong, 2009-04-28 23:25:55]

LGTM++

one sanity check question.

http://codereview.chromium.org/99160/diff/1/3
File media/base/media_posix.cc (right):

http://codereview.chromium.org/99160/diff/1/3#newcode174
Line 174: dlsym(libs[FILE_LIBAVCODEC], "av_get_bits_per_sample_format"));
:-/ I really need to fix this.  next week. next week. *sigh*

http://codereview.chromium.org/99160/diff/1/7
File media/filters/ffmpeg_demuxer.cc (left):

http://codereview.chromium.org/99160/diff/1/7#oldcode64
Line 64: stream->codec->channels);
do we just not need these values anymore?

[scherkus (not reviewing), 2009-04-28 23:31:10]

http://codereview.chromium.org/99160/diff/1/7
File media/filters/ffmpeg_demuxer.cc (left):

http://codereview.chromium.org/99160/diff/1/7#oldcode64
Line 64: stream->codec->channels);
On 2009/04/28 23:25:56, awong wrote:
> do we just not need these values anymore?

the mime types "audio/x-ffmpeg" and "video/x-ffmpeg" are clues to downstream
decoders that they can query the demuxer to expose the underlying AVStream
object.  Once they have the AVStream object, they can access all of these fields
(and more!) directly

[ralphl, 2009-04-28 23:38:29]

LGTM