Issue 99146: Improve the font fallback for 'common' characters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99146: Improve the font fallback for 'common' characters (Closed)

Created:
11 years, 7 months ago by jungshik at Google

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews_googlegroups.com, Mark Larson, xlyuan

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Change the way the fallback font for characters belonging to USCRIPT_COMMON is selected. This is to fix issue 3530 and issue 1716 (as well as internal bug 1855845). It'll also help some (unreported) edge cases. Upstream bug : https://bugs.webkit.org/show_bug.cgi?id=25464 (I have this CL up here for merging with the branch after some baking in the trunk). BUG=1855845 http://crbug.com/3530 TEST=1. Pass webkit layout tests 2. Go to http://demo.icu-project.org/icu-bin/ubrowse?go=&ch.x=0&ch.y=0&ch=ch&us=[:Script%3DCommon:] and make sure there's no regression (no character should be rendered with empty box if it didn't in the build without this patch). Upstream bug fixed and merged to Chrome

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -44 lines)			Patch
	M	third_party/WebKit/WebCore/platform/graphics/chromium/FontUtilsChromiumWin.cpp	View	1	3 chunks	+50 lines, -44 lines	0 comments	Download