Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 99132: gtest shouldn't link in gtest_main.cc, as that provides its own main(). (Closed)

Created:
11 years, 7 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
tony, bradn, M-A Ruel
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

gtest shouldn't link in gtest_main.cc, as that provides its own main(). Split gtest into two libraries, where the latter provides main(). This is consistent with the way gtest works within Google and with its automake files. Fix binaries that require gtest's main() to depend on gtest.gyp:main.

Patch Set 1 #

Patch Set 2 : passes trybot #

Patch Set 3 : retry with sln fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M build/temp_gyp/googleurl.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome.sln View 4 chunks +12 lines, -0 lines 0 comments Download
M printing/printing.gyp View 2 1 chunk +1 line, -0 lines 0 comments Download
M testing/gtest.gyp View 1 2 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Evan Martin
11 years, 7 months ago (2009-04-28 18:30:18 UTC) #1
tony
LGTM!
11 years, 7 months ago (2009-04-28 18:31:46 UTC) #2
bradn
LGTM
11 years, 7 months ago (2009-05-06 17:55:06 UTC) #3
Evan Martin
This unfortunately didn't work because the main chrome.sln isn't built from gyp yet. Hurry up, ...
11 years, 7 months ago (2009-05-06 18:25:01 UTC) #4
Evan Martin
ok, now with sln change (m-a: please review)
11 years, 7 months ago (2009-05-06 19:08:46 UTC) #5
M-A Ruel
11 years, 7 months ago (2009-05-06 19:12:12 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698