Issue 99131: Create a bookmark editor dialog interface and implement a GTK version.

Issue 99131: Create a bookmark editor dialog interface and implement a GTK version. (Closed)

Created:
11 years, 8 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Create a bookmark editor dialog interface and implement a GTK version. The GTK version is currently limited to only editing the name/url of the bookmark; I'm submitting this since it's getting big and I want a design review. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14763

Patch Set 1 #

Patch Set 2 : Fix style stuff #

Patch Set 3 : Fix windows compile errors? #

Total comments: 6

Patch Set 4 : fixes for tony #

Total comments: 1

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+516 lines, -73 lines)			Patch
M	chrome/browser/bookmarks/bookmark_context_menu.cc	View	1 2	5 chunks	+16 lines, -20 lines	0 comments	Download
A	chrome/browser/bookmarks/bookmark_editor.h	View	1 2 3	1 chunk	+44 lines, -0 lines	0 comments	Download
M	chrome/browser/browser.vcproj	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A	chrome/browser/gtk/bookmark_editor_gtk.h	View		1 chunk	+110 lines, -0 lines	0 comments	Download
A	chrome/browser/gtk/bookmark_editor_gtk.cc	View	1 2 3	1 chunk	+308 lines, -0 lines	1 comment	Download
M	chrome/browser/views/bookmark_bubble_view.cc	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/views/bookmark_editor_view.h	View		4 chunks	+6 lines, -30 lines	0 comments	Download
M	chrome/browser/views/bookmark_editor_view.cc	View		3 chunks	+20 lines, -19 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 2 3	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM, just some nits. http://codereview.chromium.org/99131/diff/1009/17 File chrome/browser/bookmarks/bookmark_editor.h (right): http://codereview.chromium.org/99131/diff/1009/17#newcode31 Line 31: // Shows the platofrm ...

11 years, 8 months ago (2009-04-28 18:00:26 UTC) #2

Elliot Glaysher

http://codereview.chromium.org/99131/diff/1009/17 File chrome/browser/bookmarks/bookmark_editor.h (right): http://codereview.chromium.org/99131/diff/1009/17#newcode31 Line 31: // Shows the platofrm specific BookmarkEditor subclass editing ...

11 years, 8 months ago (2009-04-28 19:19:35 UTC) #3

tony

11 years, 8 months ago (2009-04-28 19:24:34 UTC) #5

http://codereview.chromium.org/99131/diff/1013/30
File chrome/browser/gtk/bookmark_editor_gtk.cc (right):

http://codereview.chromium.org/99131/diff/1013/30#newcode105
Line 105: // |----------------------------------------------------------------
Awesome.

Expand Messages | Collapse Messages